Date: Wed, 27 Feb 2002 01:48:55 -0800 (PST) From: Doug Barton <DougB@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Bill Fenner <fenner@research.att.com>, <current@FreeBSD.org> Subject: Re: Broken (?) unistd.h Message-ID: <20020227014559.O31146-100000@master.gorean.org> In-Reply-To: <20020227183827.R47743-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 27 Feb 2002, Bruce Evans wrote:
> On Tue, 26 Feb 2002, Bill Fenner wrote:
>
> > Here's a patch for bind's port/freebsd/include/port_before.h .
> >
> > --- port_before.h.orig Tue Feb 26 20:57:35 2002
> > +++ port_before.h Tue Feb 26 21:02:18 2002
> > @@ -15,6 +15,7 @@
> > #define SETPWENT_VOID
> > #endif
> >
> > +#include <sys/param.h>
> > #include <sys/types.h>
>
> >From style(9):
>
> Kernel include files (i.e. sys/*.h) come first; normally, include
> <sys/types.h> OR <sys/param.h>, but not both. <sys/types.h> includes
> <sys/cdefs.h>, and it is okay to depend on that.
Based on a suggestion from someone else, I actually generated the same
patch that Bill did. Without including sys/param.h, there is no definition
of __FreeBSD_version at this point in the process, so the test always
fails. If there is a more correct way to test, I'll be glad to use it,
otherwise I'll have to go with what works.
Doug
--
"We have known freedom's price. We have shown freedom's power.
And in this great conflict, ... we will see freedom's victory."
- George W. Bush, President of the United States
State of the Union, January 28, 2002
Do YOU Yahoo!?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020227014559.O31146-100000>