Date: Sun, 25 Aug 2002 16:17:48 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org> Cc: Craig Rodrigues <rodrigc@attbi.com>, freebsd-current@FreeBSD.org Subject: Re: Question about device.hints man page Message-ID: <20020825161748.R62302@espresso.q9media.com> In-Reply-To: <20020825200236.GB82354@dragon.nuxi.com>; from obrien@FreeBSD.org on Sun, Aug 25, 2002 at 01:02:36PM -0700 References: <20020825155130.A2058@attbi.com> <1030290579.356.5.camel@twoflower> <20020825125401.A751@attbi.com> <20020825124344.P62302@espresso.q9media.com> <20020825200236.GB82354@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
David O'Brien <obrien@FreeBSD.org> writes:
> On Sun, Aug 25, 2002 at 12:43:44PM -0400, Mike Barcroft wrote:
> > Craig Rodrigues <rodrigc@attbi.com> writes:
> > > device.hints.5:
> > > $FreeBSD: src/share/man/man5/device.hints.5,v 1.3 2002/08/09 06:07:33 obrien Exp $
> > > I would like to submit the following trivial patch:
> > >
> > >
> > > --- device.hints.5.orig Sun Aug 25 12:52:02 2002
> > > +++ device.hints.5 Sun Aug 25 12:52:26 2002
> > > @@ -145,7 +145,7 @@
> > >
> > > The following example disables the ACPI driver
> > > .Bd -literal -offset indent
> > > -hint.acpi.0.disable="1"
> > > +hint.acpi.0.disabled="1"
> > > .Ed
> > > .\" .Pp
> > > .\" A control variable may look like:
> >
> >
> > Committed, thanks.
>
> Uh WAIT! Was this tested?!?
> $ grep disable /sys/boot/i386/libi386/i386_module.c
> if ((getenv("acpi_load") && !getenv("hint.acpi.0.disable"))) {
>
> "hint.acpi.0.disable=1" certainly did not load the acpi.ko module for me
> (as expected by inspecting the code). I'm backing this commit out
> someone can prove it is proper.
I checked with sys/dev/acpica/acpi.c:223 to confirm the hint name. I
think one of these two places has it misspelled. Would someone please
fix it or explain why we have differing hints for the seemingly the
same thing?
Best regards,
Mike Barcroft
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020825161748.R62302>