Date: Mon, 5 Jun 1995 01:46:05 +0400 (MSD) From: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA=?= =?KOI8-R?Q?=FE=C5=D2=CE=CF=D7=?= aka "Andrey A. Chernov, Black Mage" <ache@astral.msk.su> To: CVS-commiters@freefall.cdrom.com, cvs-sys@freefall.cdrom.com, David Greenman <davidg@freefall.cdrom.com> Cc: Bruce Evans <bde@zeta.org.au> Subject: Re: cvs commit: src/sys/kern tty.c Message-ID: <bETcYqluuN@astral.msk.su> In-Reply-To: <199506041628.JAA15415@freefall.cdrom.com>; from David Greenman at Sun, 4 Jun 1995 09:28:44 -0700 References: <199506041628.JAA15415@freefall.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
In message <199506041628.JAA15415@freefall.cdrom.com> David Greenman
writes:
>davidg 95/06/04 09:28:44
> Modified: sys/kern tty.c
> Log:
> Remove t_timeout from ttysleep() call in ttwrite() (undo part of revision
> 1.44). Nonblocking writes can't return EWOULDBLOCK so there is no point
> in timing out.
> Fixes PR 445.
> Submitted by: Bruce Evans
I disagree.
1) Variant before "fix" can't affect default case: if you don't set
t_timeout directly, it is equal to zero
(acts completely like in old case). I don't see PR 445 right now,
but can say that this fix can't fix PR unless t_timeout sets
directly by user. If user sets t_timeout directly to non-zero, he
must know what he do.
2) This "fix" break non-default case (purpose of t_timeout as introduced),
i.e. if process issue write operation on modem with hanging CTS, process
hangs forever. From very practical reasons I prefer return of EWOULDBLOCK
than hanging forever... If you try to run modem spool site with about
200 numbers, hanged modems becomes real pain.
3) t_timeout is very special case and already was non-standard as invented,
so I consider this fix like attepmt of void standartization with
big blood.
Please, back out it.
- --
Andrey A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
-----BEGIN PGP SIGNATURE-----
Version: 2.6.2i
iQCVAwUBL9IpmuJgpPLZnQjrAQH/6QQA6OS+LPDpLjElqpW+qXnAsE5WAA3HDW1I
XdTTMIW+USPsAtJS+wRKEiY/fw4Jmd2+TaXapmHVt9qTmJcGU2PzB3r1+0wLXLIg
Df9pL41+2Yf8/C60z9yqx/uHYz7imI8if3n02KkPuEnrtT8SRt6T8ycP4wpAPqNE
tBa4A/W5Q9k=
=xB2Q
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bETcYqluuN>