Date: Tue, 10 Mar 2009 17:19:48 +0100 From: Fabian Keil <freebsd-listen@fabiankeil.de> To: Guido van Rooij <guido@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r189625 - head/sys/geom/eli Message-ID: <20090310171948.1ac51696@fabiankeil.de> In-Reply-To: <200903101523.n2AFNhs1065867@svn.freebsd.org> References: <200903101523.n2AFNhs1065867@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/2BaWsgMhOF27EkVAfA2gA6m Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Guido van Rooij <guido@FreeBSD.org> wrote: > Author: guido > Date: Tue Mar 10 15:23:43 2009 > New Revision: 189625 > URL: http://svn.freebsd.org/changeset/base/189625 >=20 > Log: > When attaching a geli on boot make sure that it is detached > upon last close. (needed for a gmirror to properly shutdown > upon reboot when a geli is on top the gmirror) >=20 > Modified: > head/sys/geom/eli/g_eli.c >=20 > Modified: head/sys/geom/eli/g_eli.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/geom/eli/g_eli.c Tue Mar 10 15:19:49 2009 > (r189624) +++ head/sys/geom/eli/g_eli.c Tue Mar 10 15:23:43 > 2009 (r189625) @@ -996,6 +996,7 @@ g_eli_taste(struct g_class > *mp, struct g /* > * We have correct key, let's attach provider. > */ > + md.md_flags |=3D G_ELI_FLAG_WO_DETACH; > gp =3D g_eli_create(NULL, mp, pp, &md, mkey, nkey); > bzero(mkey, sizeof(mkey)); > bzero(&md, sizeof(md)); Detach-on-last-close is known to cause panics when scrubbing at least some ZFS pools: http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/117158 Quoting the PR: |Quoting Pawel Jakub Dawidek's response to my initial report: ||GELI's detach-on-last-close mechanism is a general purpose mechanism, it ||may not work correctly with ZFS, because ZFS sometimes closes and reopen ||providers, which will make GELI to detach. In other words you shouldn't ||configure detach-on-last-close for ZFS components.=20 Fabian --Sig_/2BaWsgMhOF27EkVAfA2gA6m Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkm2kyQACgkQBYqIVf93VJ16RgCfXr9jmNerH8V03NVtX6Zdty0R nXwAn0xwziOcO00wvoRip6LoooRgtmcE =6J7x -----END PGP SIGNATURE----- --Sig_/2BaWsgMhOF27EkVAfA2gA6m--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090310171948.1ac51696>