Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Jul 2020 21:17:46 +0000 (UTC)
From:      Mateusz Guzik <mjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r363201 - head/sys/kern
Message-ID:  <202007142117.06ELHkCG022226@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mjg
Date: Tue Jul 14 21:17:46 2020
New Revision: 363201
URL: https://svnweb.freebsd.org/changeset/base/363201

Log:
  cache: remove numcalls
  
  The counter is not very useful and if necessary the value can be
  found by summing up other counters.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==============================================================================
--- head/sys/kern/vfs_cache.c	Tue Jul 14 21:17:08 2020	(r363200)
+++ head/sys/kern/vfs_cache.c	Tue Jul 14 21:17:46 2020	(r363201)
@@ -407,7 +407,6 @@ static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW |
 STATNODE_ULONG(numneg, "Number of negative cache entries");
 STATNODE_ULONG(numcache, "Number of cache entries");
 STATNODE_COUNTER(numcachehv, "Number of namecache entries with vnodes held");
-STATNODE_COUNTER(numcalls, "Number of cache lookups");
 STATNODE_COUNTER(numdrops, "Number of dropped entries due to reaching the limit");
 STATNODE_COUNTER(dothits, "Number of '.' hits");
 STATNODE_COUNTER(dotdothits, "Number of '..' hits");
@@ -1384,8 +1383,6 @@ cache_lookup(struct vnode *dvp, struct vnode **vpp, st
 		return (0);
 	}
 #endif
-
-	counter_u64_add(numcalls, 1);
 
 	if (__predict_false(cnp->cn_namelen == 1 && cnp->cn_nameptr[0] == '.'))
 		return (cache_lookup_dot(dvp, vpp, cnp, tsp, ticksp));



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202007142117.06ELHkCG022226>