Date: Sat, 13 Mar 2010 09:41:47 -0300 From: Luiz Otavio O Souza <loos.br@gmail.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: embedded@freebsd.org, Grzegorz Bernacki <gjb@semihalf.com> Subject: Re: NAND Flash Framework for review Message-ID: <ACBA55E7-AA39-4969-A7F0-32E2A9D35AB3@gmail.com> In-Reply-To: <20100312220205.2fbc8ab7@fubar.geek.nz> References: <0AE04EFA-A3EB-4939-BD81-607C00355B67@semihalf.com> <20100312220205.2fbc8ab7@fubar.geek.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 12, 2010, at 10:02 AM, Andrew Turner wrote: > On Tue, 9 Mar 2010 00:28:53 +0100 > Rafal Jaworowski <raj@semihalf.com> wrote: >> We are looking for review, comments and any other feedback. >=20 > I've been reviewing the driver and should have some notes in the next > couple of days on areas I would like to see changes. >=20 > Andrew Rafal, first of all, i'd like to thank you, semihalf and Grzegorz for = the contribution, the code is very well written, clear and easy to = understand. That said, the code isn't ready to use, there are a few small things to = fix (ecc byte positions, bad block table for non onfi compliant devices, = there is no support to read status from ready/busy nand pin and gnand = interface doesn't work with disk->d_maxsize =3D=3D disk->d_sectorsize =3D=3D= device->blocksize). I've tested the code with two Hynix devices, one small page type = (512/16) with 64MB of capacity and the other is a large page type = (2048/64) with 512MB. The small page device works really fine, i can read the raw data and = verify ecc (the device has a YAFFS1 file system). Now i'm looking at ecc positions for the large page device which looks = like have a YAFFS2 FS on it, no luck with ecc data but raw data looks = fine. I'll wait for Andrew notes and then i gonna put some more ideas and = patches together. Luiz
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACBA55E7-AA39-4969-A7F0-32E2A9D35AB3>