Date: Mon, 30 Mar 2015 16:21:03 -0600 From: Randall Stewart <rrs@netflix.com> To: John Baldwin <jhb@freebsd.org> Cc: Davide Italiano <davide@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r280785 - in head/sys: kern netgraph/atm/sscop netgraph/atm/uni sys Message-ID: <A9C1225A-C1A1-49BD-977D-572F4C145F51@netflix.com> In-Reply-To: <3218826.nq4nR2EqCz@ralph.baldwin.cx> References: <201503281250.t2SCoOkt020297@svn.freebsd.org> <4E7E0A0A-5125-4F3A-AC0C-D428A972C954@netflix.com> <CACYV=-G28b6RpMq62zCykVtPJeJ17TTHqN3pj7rsM9Q-=nMHyg@mail.gmail.com> <3218826.nq4nR2EqCz@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
John: As I just said, Warner and I feel we can get by with making the int -> = short/short so we preserver the KPI and at the same time achieve the objective .. My big concern was no intel platforms but Warner gave me a green light = there ;-) R On Mar 30, 2015, at 10:10 AM, John Baldwin <jhb@freebsd.org> wrote: > On Saturday, March 28, 2015 01:48:49 PM Davide Italiano wrote: >> On Sat, Mar 28, 2015 at 12:04 PM, Randall Stewart <rrs@netflix.com> = wrote: >>> Hmm does the KPI include the size of the callout structure (which is >>> private)? >>>=20 >>=20 >> It's KBI, not KPI. >>=20 >>> If so I suppose we could change the c_flags/c_iflags to >>> ushort =85 >>>=20 >>=20 >> I'm not familiar with your changes enough to suggest/propose a fix. >> As I previously mentioned, this looks suspicious KBI-wise to me, and = I >> reported to you. >=20 > The KBI issue makes it much harder to MFC. In particular, even though > you could move 'c_iflags' to the end to fix most things (though not > callout_pending()), many drivers have 'struct callout foo' inside = their > softc, etc. and this would break existing modules. >=20 > OTOH, the uglier hack of adding locking in callout_deactivate() would > preserve the KBI and be safe to merge. >=20 > --=20 > John Baldwin -------- Randall Stewart rrs@netflix.com 803-317-4952
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A9C1225A-C1A1-49BD-977D-572F4C145F51>