Date: Sat, 4 Nov 2017 14:04:58 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Mark Millard <markmi@dsl-only.net>, FreeBSD Toolchain <freebsd-toolchain@freebsd.org>, svn-src-head@freebsd.org, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: svn commit: r325320 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs [breaks lld on zfs: lld uses fallocate] Message-ID: <a5a16674-34d9-dfee-9717-cd7b1a4aca9e@FreeBSD.org> In-Reply-To: <134eea8e-1a2e-d77c-f7fa-01e14db7f47b@FreeBSD.org> References: <6140C4E2-168F-4E5D-B3C2-717ECB67C980@dsl-only.net> <134eea8e-1a2e-d77c-f7fa-01e14db7f47b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/11/2017 13:41, Andriy Gapon wrote:
> On 04/11/2017 12:32, Mark Millard wrote:
>> if (int Err = ::posix_fallocate(FD, 0, Size)) {
>> if (Err != EOPNOTSUPP)
>> return std::error_code(Err, std::generic_category());
>> }
>
> The commit message that you didn't include into your reply contains some useful
> information that authors / maintainers of this code should probably take into
> account:
>
>> Please note that EINVAL is used to report that the underlying file system
>> does not support the operation (POSIX.1-2008).
>
> Here is a link for that:
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/posix_fallocate.html
>
My response above is quite dry, so I want to add this.
Thank you very much for the deep analysis.
I am sorry for the trouble that my change caused, but I think that its root
cause lies elsewhere (lld, posix).
--
Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a5a16674-34d9-dfee-9717-cd7b1a4aca9e>