Date: Fri, 5 Jul 2002 07:40:04 -0700 (PDT) From: Ruslan Ermilov <ru@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/40047: "make release" fails in games/adventure (yesterday's RELENG_4) Message-ID: <200207051440.g65Ee43D030758@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/40047; it has been noted by GNATS.
From: Ruslan Ermilov <ru@FreeBSD.org>
To: David Schultz <dschultz@uclink.Berkeley.EDU>,
Trevor Johnson <trevor@FreeBSD.org>
Cc: re@FreeBSD.org, bug-followup@FreeBSD.org
Subject: Re: bin/40047: "make release" fails in games/adventure (yesterday's RELENG_4)
Date: Fri, 5 Jul 2002 17:37:06 +0300
[Sorry for crossposting to re@, but this seemed reasonable.]
On Fri, Jul 05, 2002 at 06:00:07AM -0700, David Schultz wrote:
> The following reply was made to PR bin/40047; it has been noted by GNATS.
>
> From: David Schultz <dschultz@uclink.Berkeley.EDU>
> To: freebsd-gnats-submit@FreeBSD.org, trevor@FreeBSD.org
> Cc:
> Subject: Re: bin/40047: "make release" fails in games/adventure (yesterday's RELENG_4)
> Date: Fri, 5 Jul 2002 05:54:39 -0700
>
> The following patch should fix the problem. The compat libraries
> are installed in /usr/lib/compat, but they were being cleaned from
> /usr/lib.
>
> --- src/lib/compat/Makefile.inc 2002/04/18 06:46:34 1.9
> +++ src/lib/compat/Makefile.inc 2002/07/05 12:52:18
> @@ -7,9 +7,9 @@
> beforeinstall: __remove-stale-libs
> __remove-stale-libs: .PHONY
> .for lib in ${LIBS}
> -.if exists(${DESTDIR}${SHLIBDIR}/${lib})
> - -chflags noschg ${DESTDIR}${SHLIBDIR}/${lib}
> - rm -f ${DESTDIR}${SHLIBDIR}/${lib}
> +.if exists(${DESTDIR}${LIBCOMPATDIR}/${lib})
> + -chflags noschg ${DESTDIR}${LIBCOMPATDIR}/${lib}
> + rm -f ${DESTDIR}${LIBCOMPATDIR}/${lib}
> .endif
> .endfor
> .endif
>
No, this patch is incorrect. When installing compat libs, their
old copies from /usr/lib should be deleted. This is what this
code already does.
As for the problem, Trevor was attempting to build the 5.0-CURRENT
snapshot on a 4.x box in an unsupported way (using the RELENG_4's
release/Makefile), as could be seen from How-To-Repeat section or
looking at the build logs. To build the 4.x snapshot, one needs
to supply the RELEASETAG=RELENG_4 as documented in the release(7)
manpage. To build the 5.0-CURRENT snapshot on a 4.x box, one needs
to:
cd /usr/src-4.x/release; make -f /usr/src-5.0/release/Makefile ...
OTOH, it would probably be a good idea to make RELEASETAG default
to RELENG_4 on RELENG_4, and default to RELENG_4_6 on RELENG_4_6,
similar to how this is done in Makefile.inc1's update: target.
(Someone from re@ needs to fix the Makefile.inc1 on RELENG_4_6
to track the RELENG_4_6, like in RELENG_4_4 and RELENG_4_5.)
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207051440.g65Ee43D030758>