Date: Tue, 1 Aug 2006 17:28:10 +0000 (UTC) From: Qing Li <qingli@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/net if_vlan.c Message-ID: <200608011728.k71HSA9m019497@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
qingli 2006-08-01 17:28:10 UTC
FreeBSD src repository
Modified files:
sys/net if_vlan.c
Log:
In vlan_input(), if the network interface does not perform h/w based
vlan tag processing, the code will use bcopy() to remove the vlan
tag field but the code copies 2 bytes too many, which essentially
overwrites the protocol type field.
Also, a tag value of -1 is generated for unrecognized interface type,
which would cause an invalid memory access in the vlans[] array.
In addition, removed a line of dead code and its associated comments.
Reviewed by: sam
Revision Changes Path
1.107 +9 -15 src/sys/net/if_vlan.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200608011728.k71HSA9m019497>