Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Jun 2004 10:25:19 GMT
From:      Juli Mallett <jmallett@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 54809 for review
Message-ID:  <200406131025.i5DAPJIM099532@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=54809

Change 54809 by jmallett@jmallett_oingo on 2004/06/13 10:24:58

	Totally don't overlook intent like a chump.

Affected files ...

.. //depot/projects/mips/sys/mips/sgimips/gio/gio.c#4 edit

Differences ...

==== //depot/projects/mips/sys/mips/sgimips/gio/gio.c#4 (text+ko) ====

@@ -23,7 +23,7 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/mips/sys/mips/sgimips/gio/gio.c#3 $
+ * $P4: //depot/projects/mips/sys/mips/sgimips/gio/gio.c#4 $
  */
 
 #include <sys/cdefs.h>
@@ -88,9 +88,9 @@
 	device_t dev;
 	int error;
 
-	product = bus_space_read_4(iv->gi_tag, iv->gi_handle, 0);
 	/* XXX subverts bus space */
 	error = check_address((char *)MIPS_PHYS_TO_KSEG1(iv->gi_handle));
+	product = bus_space_read_4(iv->gi_tag, iv->gi_handle, 0);
 	if (error != 0)
 		return (ENODEV);
 	for (gd = gio_devices; gd->gd_name != NULL; gd++) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200406131025.i5DAPJIM099532>