Date: Sun, 31 Jul 2005 10:14:00 -0700 From: Sam Leffler <sam@errno.com> To: Christian Brueffer <chris@unixpages.org> Cc: current@freebsd.org Subject: Re: [PATCH] fwip(4) panic on attach Message-ID: <42ED06D8.70506@errno.com> In-Reply-To: <20050731142625.GC1190@unixpages.org> References: <20050731142625.GC1190@unixpages.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Christian Brueffer wrote: > Hi, > > in CURRENT and RELENG_6 I get a reproducible panic with fwip(4) when > plugging in my firewire cardbus card. The following patch fixes it, > but I'm not sure if it's correct. > > The interface works after applying the patch. > > Index: if_fwip.c > =================================================================== > RCS file: /data/ncvs/freebsd/src/sys/dev/firewire/if_fwip.c,v > retrieving revision 1.7 > diff -u -r1.7 if_fwip.c > --- if_fwip.c 10 Jun 2005 16:49:08 -0000 1.7 > +++ if_fwip.c 31 Jul 2005 14:01:52 -0000 > @@ -171,11 +171,13 @@ > > fwip = ((struct fwip_softc *)device_get_softc(dev)); > unit = device_get_unit(dev); > + > + bzero(fwip, sizeof(struct fwip_softc)); > + > ifp = fwip->fw_softc.fwip_ifp = if_alloc(IFT_IEEE1394); > if (ifp == NULL) > return (ENOSPC); > > - bzero(fwip, sizeof(struct fwip_softc)); > /* XXX */ > fwip->dma_ch = -1; > I thought the softc was guaranteed to be zero'd; can't you just delete the bzero? Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42ED06D8.70506>