Date: Thu, 1 Jun 2017 16:17:46 +0000 From: Brooks Davis <brooks@freebsd.org> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>, Ngie Cooper <ngie@FreeBSD.org>, Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <20170601161746.GB60464@spindle.one-eyed-alien.net> In-Reply-To: <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--zYM0uCDKw75PZbzx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 01, 2017 at 08:11:45AM -0700, Marcel Moolenaar wrote: >=20 > > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) <yaneurabeya@gm= ail.com> wrote: > >=20 > >=20 > >> On May 31, 2017, at 10:03 PM, Brooks Davis <brooks@FreeBSD.org> wrote: > >>=20 > >> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: > >>> Author: ngie > >>> Date: Wed May 31 08:01:12 2017 > >>> New Revision: 319295 > >>> URL: https://svnweb.freebsd.org/changeset/base/319295 > >>>=20 > >>> Log: > >>> Update the usr.bin/mkimg golden test output files after ^/head@r319125 > >>>=20 > >>> ^/head@r319125 changed the location of the backup pmbr, requiring the > >>> output files to be regenerated, since they're binary disk dumps. > >>>=20 > >>> The output files were regenerated with "make rebase"--fixed in > >>> ^/head@r319294. > >>=20 > >> These should not be stored uuencoded. It serves no purpose other > >> than bloating the repo and causing spammy commit mails like this one > >> where we got a huge tail of garbage output. > >=20 > > Hi Brooks, > > I???m not entirely sure why the files were uuencoded to be honest. I t= hink that???s a good question for Marcel and some of the folks at Juniper, = since they wrote the tool/tests. >=20 > Result files used to start off as binary files. uuencoding is a given in= that case. I eventually switched to using hexdump -C, because that makes = it easier to analyze and understand differences. The uuencoding was kept t= o remain independent of version control system, file attributes and end-of-= line characteristics of the host machine: nothing more annoying that checki= ng out textual result files and have test failures because ???\n??? was rep= laced by ???\r\n???. >=20 > Even if the files aren???t unencoded, there???s always someone who treats= it as spammy and a tail of garbage. It???s just a knee-jerk reaction to se= eing something that isn???t understood, I think. As such, there???s no reas= on to change ??? in fact, changing would be bloating the repo. hexdump -C would make sense. Direct commits of the compressed files would also make sense. Uuencoding gzip'd data is absurd given that we don't (and never again will) support repositories that don't support binary data. The diffs produced are meaningless. I don't advocate replacing these files agressively, but when updating files we should be thinking about switching away from uuencoding. -- Brooks --zYM0uCDKw75PZbzx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJZMD4pAAoJEKzQXbSebgfAjW4H+QGMqrRUeCAi0jQlsSwDFR3W qF1MLBfpnHrUKBqbbqfd+8Pd6SHlZN/9zdE6JX+8P1b/ymZnKHuZhDAyBSxDqUje 5gWFJBFCFECSeWSztGi40CWb+bW2XnbKwH/1HkdeVHzZS+o7OYSSL8cxgtJ2Kw7i i+1juzJjRaGtfW9rVjMOmPg2Kk38WXCYFqlFGXE3tcOIXVVoGG7+hAavqlUpp78h XZzQaW7OKJwc0LDDfldbiwsR6G2HKsakHaxGNKqRCDhzSkZOxuzj5NKnI8GMKlBN moAykgnQJtwB1LDlcuf1/WQpyBZtdY8NBtVdoGXUMspMWY64rrZJbx1CVHtVyCs= =kDef -----END PGP SIGNATURE----- --zYM0uCDKw75PZbzx--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170601161746.GB60464>