Date: Wed, 24 Jan 2024 18:24:26 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 820401bf1769 - main - nl_types.h: explicitly include cdefs.h Message-ID: <CANCZdfoY-kBd9KRcRbWDOPCcu5kGC_z1zQPkNF%2B5=HEa%2BUJ46Q@mail.gmail.com> In-Reply-To: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org> References: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] This was one of the things i wanted to comment on the that review. This change should be done as a special Linux sys/param.h that includes ctypes.h and then includes the next sys/param.h. A large number of the changes from that review are similar and i wanted yo think through the right solution. This is fragile: I'm likely to remove it again because it violates style(9) and has no docs around it. Warner On Wed, Jan 24, 2024, 3:05 PM Ed Maste <emaste@freebsd.org> wrote: > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=820401bf176996e41091d2e4190aded12a966b1d > > commit 820401bf176996e41091d2e4190aded12a966b1d > Author: Val Packett <val@packett.cool> > AuthorDate: 2024-01-16 18:42:26 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2024-01-24 21:59:18 +0000 > > nl_types.h: explicitly include cdefs.h > > This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping from > Linux/musl, they were missing. > > Sponsored by: https://www.patreon.com/valpackett > Pull Request: https://github.com/freebsd/freebsd-src/pull/1066 > --- > include/nl_types.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/nl_types.h b/include/nl_types.h > index 120d1911631f..6ba15132126d 100644 > --- a/include/nl_types.h > +++ b/include/nl_types.h > @@ -34,6 +34,7 @@ > #ifndef _NL_TYPES_H_ > #define _NL_TYPES_H_ > > +#include <sys/cdefs.h> > #include <sys/types.h> > > #ifdef _NLS_PRIVATE > [-- Attachment #2 --] <div dir="auto">This was one of the things i wanted to comment on the that review.<div dir="auto"><br></div><div dir="auto">This change should be done as a special Linux sys/param.h that includes ctypes.h and then includes the next sys/param.h.</div><div dir="auto"><br></div><div dir="auto">A large number of the changes from that review are similar and i wanted yo think through the right solution.</div><div dir="auto"><br></div><div dir="auto">This is fragile: I'm likely to remove it again because it violates style(9) and has no docs around it.</div><div dir="auto"><br></div><div dir="auto">Warner</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jan 24, 2024, 3:05 PM Ed Maste <<a href="mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The branch main has been updated by emaste:<br> <br> URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=820401bf176996e41091d2e4190aded12a966b1d" rel="noreferrer noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=820401bf176996e41091d2e4190aded12a966b1d</a><br>; <br> commit 820401bf176996e41091d2e4190aded12a966b1d<br> Author: Val Packett <val@packett.cool><br> AuthorDate: 2024-01-16 18:42:26 +0000<br> Commit: Ed Maste <emaste@FreeBSD.org><br> CommitDate: 2024-01-24 21:59:18 +0000<br> <br> nl_types.h: explicitly include cdefs.h<br> <br> This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping from<br> Linux/musl, they were missing.<br> <br> Sponsored by: <a href="https://www.patreon.com/valpackett" rel="noreferrer noreferrer" target="_blank">https://www.patreon.com/valpackett</a><br>; Pull Request: <a href="https://github.com/freebsd/freebsd-src/pull/1066" rel="noreferrer noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1066</a><br>; ---<br> include/nl_types.h | 1 +<br> 1 file changed, 1 insertion(+)<br> <br> diff --git a/include/nl_types.h b/include/nl_types.h<br> index 120d1911631f..6ba15132126d 100644<br> --- a/include/nl_types.h<br> +++ b/include/nl_types.h<br> @@ -34,6 +34,7 @@<br> #ifndef _NL_TYPES_H_<br> #define _NL_TYPES_H_<br> <br> +#include <sys/cdefs.h><br> #include <sys/types.h><br> <br> #ifdef _NLS_PRIVATE<br> </blockquote></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoY-kBd9KRcRbWDOPCcu5kGC_z1zQPkNF%2B5=HEa%2BUJ46Q>