Date: Wed, 24 Jan 2024 18:24:26 -0700 From: Warner Losh <imp@bsdimp.com> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 820401bf1769 - main - nl_types.h: explicitly include cdefs.h Message-ID: <CANCZdfoY-kBd9KRcRbWDOPCcu5kGC_z1zQPkNF%2B5=HEa%2BUJ46Q@mail.gmail.com> In-Reply-To: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org> References: <202401242205.40OM5Jiq042676@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--000000000000f8abb3060fbb0aa2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This was one of the things i wanted to comment on the that review. This change should be done as a special Linux sys/param.h that includes ctypes.h and then includes the next sys/param.h. A large number of the changes from that review are similar and i wanted yo think through the right solution. This is fragile: I'm likely to remove it again because it violates style(9) and has no docs around it. Warner On Wed, Jan 24, 2024, 3:05=E2=80=AFPM Ed Maste <emaste@freebsd.org> wrote: > The branch main has been updated by emaste: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41091d2e4190aded= 12a966b1d > > commit 820401bf176996e41091d2e4190aded12a966b1d > Author: Val Packett <val@packett.cool> > AuthorDate: 2024-01-16 18:42:26 +0000 > Commit: Ed Maste <emaste@FreeBSD.org> > CommitDate: 2024-01-24 21:59:18 +0000 > > nl_types.h: explicitly include cdefs.h > > This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping from > Linux/musl, they were missing. > > Sponsored by: https://www.patreon.com/valpackett > Pull Request: https://github.com/freebsd/freebsd-src/pull/1066 > --- > include/nl_types.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/nl_types.h b/include/nl_types.h > index 120d1911631f..6ba15132126d 100644 > --- a/include/nl_types.h > +++ b/include/nl_types.h > @@ -34,6 +34,7 @@ > #ifndef _NL_TYPES_H_ > #define _NL_TYPES_H_ > > +#include <sys/cdefs.h> > #include <sys/types.h> > > #ifdef _NLS_PRIVATE > --000000000000f8abb3060fbb0aa2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">This was one of the things i wanted to comment on the tha= t review.<div dir=3D"auto"><br></div><div dir=3D"auto">This change should b= e done as a special Linux sys/param.h that includes ctypes.h and then inclu= des the next sys/param.h.</div><div dir=3D"auto"><br></div><div dir=3D"auto= ">A large number of the changes from that review are similar and i wanted y= o think through the right solution.</div><div dir=3D"auto"><br></div><div d= ir=3D"auto">This is fragile: I'm likely to remove it again because it v= iolates style(9) and has no docs around it.</div><div dir=3D"auto"><br></di= v><div dir=3D"auto">Warner</div></div><br><div class=3D"gmail_quote"><div d= ir=3D"ltr" class=3D"gmail_attr">On Wed, Jan 24, 2024, 3:05=E2=80=AFPM Ed Ma= ste <<a href=3D"mailto:emaste@freebsd.org">emaste@freebsd.org</a>> wr= ote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;= border-left:1px #ccc solid;padding-left:1ex">The branch main has been updat= ed by emaste:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41= 091d2e4190aded12a966b1d" rel=3D"noreferrer noreferrer" target=3D"_blank">ht= tps://cgit.FreeBSD.org/src/commit/?id=3D820401bf176996e41091d2e4190aded12a9= 66b1d</a><br> <br> commit 820401bf176996e41091d2e4190aded12a966b1d<br> Author:=C2=A0 =C2=A0 =C2=A0Val Packett <val@packett.cool><br> AuthorDate: 2024-01-16 18:42:26 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Ed Maste <emaste@FreeBSD.org><br> CommitDate: 2024-01-24 21:59:18 +0000<br> <br> =C2=A0 =C2=A0 nl_types.h: explicitly include cdefs.h<br> <br> =C2=A0 =C2=A0 This file uses __BEGIN_DECLS/__END_DECLS. When bootstrapping = from<br> =C2=A0 =C2=A0 Linux/musl, they were missing.<br> <br> =C2=A0 =C2=A0 Sponsored by:=C2=A0 =C2=A0<a href=3D"https://www.patreon.com/= valpackett" rel=3D"noreferrer noreferrer" target=3D"_blank">https://www.pat= reon.com/valpackett</a><br> =C2=A0 =C2=A0 Pull Request:=C2=A0 =C2=A0<a href=3D"https://github.com/freeb= sd/freebsd-src/pull/1066" rel=3D"noreferrer noreferrer" target=3D"_blank">h= ttps://github.com/freebsd/freebsd-src/pull/1066</a><br> ---<br> =C2=A0include/nl_types.h | 1 +<br> =C2=A01 file changed, 1 insertion(+)<br> <br> diff --git a/include/nl_types.h b/include/nl_types.h<br> index 120d1911631f..6ba15132126d 100644<br> --- a/include/nl_types.h<br> +++ b/include/nl_types.h<br> @@ -34,6 +34,7 @@<br> =C2=A0#ifndef _NL_TYPES_H_<br> =C2=A0#define _NL_TYPES_H_<br> <br> +#include <sys/cdefs.h><br> =C2=A0#include <sys/types.h><br> <br> =C2=A0#ifdef _NLS_PRIVATE<br> </blockquote></div> --000000000000f8abb3060fbb0aa2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoY-kBd9KRcRbWDOPCcu5kGC_z1zQPkNF%2B5=HEa%2BUJ46Q>