Date: Wed, 4 Dec 2002 18:54:18 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Nate Lawson <nate@root.org> Cc: Kirk McKusick <mckusick@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/sbin/dump dump.8 main.c Message-ID: <20021204185050.M747-100000@gamplex.bde.org> In-Reply-To: <Pine.BSF.4.21.0212031055050.7407-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 3 Dec 2002, Nate Lawson wrote:
> Minor comments, thx for doing this.
Even more minor comment.
> > --- src/sbin/dump/main.c:1.42 Tue Nov 26 18:18:56 2002
> > +++ src/sbin/dump/main.c Tue Dec 3 10:21:09 2002
> >
> > + if ((diskfd = open(snapname, O_RDONLY)) < 0) {
> > + unlink(snapname);
> > + errx(X_STARTUP, "Cannot open %s: %s\n",
> > + snapname, strerror(errno));
Should be:
err(X_STARTUP, "Cannot open %s", snapname);
(Don't reimplement err() using errx() or misimplement it by printing an
extra newline.)
> > + }
> > + unlink(snapname);
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021204185050.M747-100000>