Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 May 2006 07:27:38 -0700 (PDT)
From:      Doug Ambrisko <ambrisko@ambrisko.com>
To:        Alexander Leidinger <Alexander@Leidinger.net>
Cc:        freebsd-emulation@freebsd.org
Subject:   Re: Linux emulation enhancement to emulate device nodes and some SCSI stuff
Message-ID:  <200605031427.k43ERcUI083923@ambrisko.com>
In-Reply-To: <20060503105431.k8rmf62jlwoscwgc@netchild.homeip.net>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Leidinger writes:
| Quoting Doug Ambrisko <ambrisko@ambrisko.com> (from Thu, 27 Apr 2006  
| 14:48:28 -0700 (PDT)):
| 
| > To get the LSI RAID SAS to work under Linux emulation we need to emulate
| > more of Linux type stuff.  I've put patches up at:
| > 	http://www.ambrisko.com/doug/linux.patches
| 
| In case you didn't got any responses: go ahead, we don't have an  
| active linuoxlator guru ATM.
| 
| Some generic comments (only a *quick* C-level review, not a  
| design/concept-level review):
| ---snip--
| @@ -470,7 +522,9 @@ linux_fstat64(struct thread *td, struct
|   #endif
| 
|   	error = kern_fstat(td, args->fd, &buf);
| +	translate_fd_major_minor(td, args->fd, &buf);
|   	if (!error)
| +		translate_fd_major_minor(td, args->fd, &buf);
|   		error = stat64_copyout(&buf, args->statbuf);
| ---snip---
| 
| Bug, missing {} for the "if".

Good catch.  The error is that I pasted in a 2nd bogus
	translate_fd_major_minor(td, args->fd, &buf);
I fixed that.

Thanks for looking at it.  I'll check on my make universe and check it
in if that worked okay.

Doug A.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200605031427.k43ERcUI083923>