Date: Tue, 15 Mar 2016 09:48:22 -0700 From: Adrian Chadd <adrian.chadd@gmail.com> To: Hans Petter Selasky <hselasky@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r296910 - head/sys/ofed/drivers/net/mlx4 Message-ID: <CAJ-VmokioNoU9dPWZLXsWcR91CeUGmH%2BGUajVzsMhLeVGz_0CQ@mail.gmail.com> In-Reply-To: <201603151553.u2FFrbZG081474@repo.freebsd.org> References: <201603151553.u2FFrbZG081474@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
hiya, make sure you set M_HASHTYPE_ appropriately? -adrian On 15 March 2016 at 08:53, Hans Petter Selasky <hselasky@freebsd.org> wrote: > Author: hselasky > Date: Tue Mar 15 15:53:37 2016 > New Revision: 296910 > URL: https://svnweb.freebsd.org/changeset/base/296910 > > Log: > Use hardware computed Toeplitz hash for incoming flowids > > Use the Toeplitz hash value as source for the flowid. This makes the > hash value more suitable for so-called hash bucket algorithms which > are used in the FreeBSD's TCP/IP stack when RSS is enabled. > > Sponsored by: Mellanox Technologies > MFC after: 1 week > > Modified: > head/sys/ofed/drivers/net/mlx4/en_rx.c > head/sys/ofed/drivers/net/mlx4/en_tx.c > > Modified: head/sys/ofed/drivers/net/mlx4/en_rx.c > ============================================================================== > --- head/sys/ofed/drivers/net/mlx4/en_rx.c Tue Mar 15 15:47:26 2016 (r296909) > +++ head/sys/ofed/drivers/net/mlx4/en_rx.c Tue Mar 15 15:53:37 2016 (r296910) > @@ -616,7 +616,8 @@ int mlx4_en_process_rx_cq(struct net_dev > goto next; > } > > - mb->m_pkthdr.flowid = cq->ring; > + /* forward Toeplitz compatible hash value */ > + mb->m_pkthdr.flowid = be32_to_cpu(cqe->immed_rss_invalid); > M_HASHTYPE_SET(mb, M_HASHTYPE_OPAQUE); > mb->m_pkthdr.rcvif = dev; > if (be32_to_cpu(cqe->vlan_my_qpn) & > > Modified: head/sys/ofed/drivers/net/mlx4/en_tx.c > ============================================================================== > --- head/sys/ofed/drivers/net/mlx4/en_tx.c Tue Mar 15 15:47:26 2016 (r296909) > +++ head/sys/ofed/drivers/net/mlx4/en_tx.c Tue Mar 15 15:53:37 2016 (r296910) > @@ -1060,7 +1060,7 @@ mlx4_en_transmit(struct ifnet *dev, stru > > /* Compute which queue to use */ > if (M_HASHTYPE_GET(m) != M_HASHTYPE_NONE) { > - i = m->m_pkthdr.flowid % priv->tx_ring_num; > + i = (m->m_pkthdr.flowid % 128) % priv->tx_ring_num; > } > else { > i = mlx4_en_select_queue(dev, m); >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokioNoU9dPWZLXsWcR91CeUGmH%2BGUajVzsMhLeVGz_0CQ>