Date: Wed, 1 Feb 2006 23:00:30 GMT From: Jilles Tjoelker <jilles@stack.nl> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/89410: [PATCH] sh(1) missing \u interpolation and bug/fix in \W Message-ID: <200602012300.k11N0UpA026633@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/89410; it has been noted by GNATS. From: Jilles Tjoelker <jilles@stack.nl> To: bug-followup@FreeBSD.org, bsd@rubyforge.org Cc: Subject: Re: bin/89410: [PATCH] sh(1) missing \u interpolation and bug/fix in \W Date: Wed, 1 Feb 2006 23:58:10 +0100 Some comments about the patch: - You should not call getpwuid() for every prompt, perhaps use $USER instead for the \u expansion - \w/\W should use more something like $PWD (leave the symlinks) and just compare with $HOME (bash3 does the same). This needs wider changes over the code though. - The code in HEAD seems to have some other bugfixes since you patched it. - Your dot.shrc patch looks way too redhatty :P -- Jilles Tjoelker
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602012300.k11N0UpA026633>