Date: Wed, 04 Dec 2013 11:49:11 -0600 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r258928 - head/sys/kern Message-ID: <529F6B17.2060302@freebsd.org> In-Reply-To: <20131204174123.GX59496@kib.kiev.ua> References: <201312041638.rB4Gcf9g093085@svn.freebsd.org> <20131204174123.GX59496@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/04/13 11:41, Konstantin Belousov wrote: > On Wed, Dec 04, 2013 at 04:38:41PM +0000, Nathan Whitehorn wrote: >> Author: nwhitehorn >> Date: Wed Dec 4 16:38:40 2013 >> New Revision: 258928 >> URL: http://svnweb.freebsd.org/changeset/base/258928 >> >> Log: >> Rename sysctl kern.supported_abis to kern.supported_archs, since it gives >> the set of MACHINE_ARCH values that can be run. >> >> Modified: >> head/sys/kern/kern_mib.c >> >> Modified: head/sys/kern/kern_mib.c >> ============================================================================== >> --- head/sys/kern/kern_mib.c Wed Dec 4 16:06:23 2013 (r258927) >> +++ head/sys/kern/kern_mib.c Wed Dec 4 16:38:40 2013 (r258928) >> @@ -261,11 +261,11 @@ sysctl_hw_machine_arch(SYSCTL_HANDLER_AR >> SYSCTL_PROC(_hw, HW_MACHINE_ARCH, machine_arch, CTLTYPE_STRING | CTLFLAG_RD, >> NULL, 0, sysctl_hw_machine_arch, "A", "System architecture"); >> >> -SYSCTL_STRING(_kern, OID_AUTO, supported_abis, CTLFLAG_RD | CTLFLAG_MPSAFE, >> +SYSCTL_STRING(_kern, OID_AUTO, supported_archs, CTLFLAG_RD | CTLFLAG_MPSAFE, >> #ifdef COMPAT_FREEBSD32 >> - MACHINE_ARCH " " MACHINE_ARCH32, 0, "List of supported ABIs"); >> + MACHINE_ARCH " " MACHINE_ARCH32, 0, "Supported architectures for binaries"); >> #else >> - MACHINE_ARCH, 0, "List of supported ABIs"); >> + MACHINE_ARCH, 0, "Supported architectures for binaries"); >> #endif > Solaris called the same concept an ISA, as far as I remember. > You do not intend to list foreign systems ABI emulators there ? The idea is to have something purely the same in meaning as hw.machine_arch, which does not involve listing foreign ABIs and is also why it is "arch" instead of "isa" (since it is "machine_arch"). I'm happy to rename it again if there is a clear consensus, though, although there is some risk of bikeshedding. I personally have no opinion on what it is called so long as it exists. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?529F6B17.2060302>