Date: Wed, 4 May 2011 11:29:40 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Ed Schouten <ed@80386.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Nathan Whitehorn <nwhitehorn@FreeBSD.org> Subject: Re: svn commit: r221419 - head/release Message-ID: <BB7203C3-39B1-4D31-B914-533186534B9E@FreeBSD.org> In-Reply-To: <20110504111759.GK2183@hoeg.nl> References: <201105040252.p442qfI4027516@svn.freebsd.org> <20110504111759.GK2183@hoeg.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 4, 2011, at 11:17 AM, Ed Schouten wrote:
> Hi Nathan,
>
> * Nathan Whitehorn <nwhitehorn@FreeBSD.org>, 20110504 04:52:
>> chroot $2 /bin/sh -c "cd /usr/src && make $MAKE_FLAGS buildworld buildkernel" || exit 1
>> +chroot $2 /bin/sh -c "cd /usr/src/release && make obj" || exit 1
>> chroot $2 /bin/sh -c "cd /usr/src/release && make release" || exit 1
>> chroot $2 /bin/sh -c "cd /usr/src/release && make install DESTDIR=/R" || exit 1
>
> Wouldn't it be a bit more elegant to do something like this?
>
> chroot $2 make -C /usr/src/release obj
>
> Also, if you enable set -e, the script terminates upon error.
Which is as bad as well as it needs to cleanup devfs mounts etc. in case of
errors. I am trying to get one finished and will post the results as well as
possible error cases I have hit so we can generally improve the script and
make it more robust. So far I am on build #4 ;-)
/bz
--
Bjoern A. Zeeb You have to have visions!
Stop bit received. Insert coin for new address family.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BB7203C3-39B1-4D31-B914-533186534B9E>