Date: Mon, 19 Jan 2026 16:41:12 -0300 From: Jose Luis Duran <jlduran@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: db3b39f063d9 - main - libjail: extend struct handlers to included MAC labels Message-ID: <CAPwQLced3tLXfrAN2S=R03QWijT0yQcCtmgKmnUmyuyTt64NcQ@mail.gmail.com> In-Reply-To: <6969853a.3b3a2.692d2f0d@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Thu, Jan 15, 2026 at 9:25 PM Kyle Evans <kevans@freebsd.org> wrote: > > The branch main has been updated by kevans: > > URL: https://cgit.FreeBSD.org/src/commit/?id=db3b39f063d9f05ee808b9c5a11146ed6810d857 > > commit db3b39f063d9f05ee808b9c5a11146ed6810d857 > Author: Kyle Evans <kevans@FreeBSD.org> > AuthorDate: 2025-11-27 05:24:14 +0000 > Commit: Kyle Evans <kevans@FreeBSD.org> > CommitDate: 2026-01-16 00:23:40 +0000 > > libjail: extend struct handlers to included MAC labels > > MAC label handling is a little special; to avoid being too disruptive, > we allocate a `mac_t *` here for the value so that we can mac_prepare() > or mac_from_text() into. As a result, we need: > > - A custom free() handler to avoid leaking the *jp_value > - A custom jailparam_get() handler to mac_prepare() the mac_t and > populate the iove properly, so that the kernel doesn't have to > do something funky like copyin, dereference, copyin again. > - A custom jailparam_set() handler to similarly populate the iovec > properly. > > Reviewed by: jamie > Differential Revision: https://reviews.freebsd.org/D53960 Hi Kyle! After this commit, the following tests are failing: - https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/27642/testReport/junit/bin.pkill/pgrep-j_test/main/ - https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/27642/testReport/junit/bin.pkill/pkill-j_test/main/ Seems like "jls -s" is not working. -- Jose Luis Duranhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPwQLced3tLXfrAN2S=R03QWijT0yQcCtmgKmnUmyuyTt64NcQ>