Date: Fri, 01 Dec 2006 15:30:32 -0800 From: Doug Barton <dougb@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: EHCI problem on -current, and unknown devs Message-ID: <4570BB18.3040405@FreeBSD.org> In-Reply-To: <200612011225.02780.jhb@freebsd.org> References: <4564996D.50808@FreeBSD.org> <200611301443.31419.jhb@freebsd.org> <456FA276.6050706@videotron.ca> <200612011225.02780.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> Sign bug on my part. try this:
>
> Index: subr_rman.c
> ===================================================================
> RCS file: /usr/cvs/src/sys/kern/subr_rman.c,v
> retrieving revision 1.53
> diff -u -r1.53 subr_rman.c
> --- subr_rman.c 11 Sep 2006 19:31:52 -0000 1.53
> +++ subr_rman.c 1 Dec 2006 17:22:25 -0000
> @@ -61,6 +61,7 @@
> #include <sys/param.h>
> #include <sys/systm.h>
> #include <sys/kernel.h>
> +#include <sys/limits.h>
> #include <sys/lock.h>
> #include <sys/malloc.h>
> #include <sys/mutex.h>
> @@ -169,10 +170,12 @@
> mtx_lock(rm->rm_mtx);
>
> /* Skip entries before us. */
> - for (s = TAILQ_FIRST(&rm->rm_list);
> - s && s->r_end + 1 < r->r_start;
> - s = TAILQ_NEXT(s, r_link))
> - ;
> + TAILQ_FOREACH(s, &rm->rm_link, r_link) {
> + if (s->r_end == ULONG_MAX)
> + break;
> + if (s->r_end + 1 >= r->r_start)
> + break;
> + }
>
> /* If we ran off the end of the list, insert at the tail. */
> if (s == NULL) {
>
With up to date -current sources, this doesn't compile for me:
/usr/local/libexec/ccache/world-cc -c -O -pipe -std=c99 -g -Wall
-Wredundant-decls -Wnested-externs -Wstrict-prototypes
-Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
-fformat-extensions -nostdinc -I- -I. -I/usr/local/src/sys
-I/usr/local/src/sys/contrib/altq -D_KERNEL
-DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
-finline-limit=8000 --param inline-unit-growth=100 --param
large-function-growth=1000 -mno-align-long-strings
-mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2
-mno-sse3 -ffreestanding -Werror /usr/local/src/sys/kern/subr_rman.c
/usr/local/src/sys/kern/subr_rman.c: In function `rman_manage_region':
/usr/local/src/sys/kern/subr_rman.c:173: error: structure has no
member named `tqh_first'
*** Error code 1
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4570BB18.3040405>