Date: Thu, 20 Aug 2015 13:29:17 +0000 From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: George Neville-Neil <gnn@neville-neil.com> Cc: "Alexander V. Chernikov" <melifaro@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286955 - in head/sys: net netinet netinet6 Message-ID: <F83673EF-7327-4A3B-87DB-1DF7393D94E7@FreeBSD.org> In-Reply-To: <46D09C16-85BD-4E99-8600-16280AC9397A@neville-neil.com> References: <201508201205.t7KC5IoT012658@repo.freebsd.org> <46D09C16-85BD-4E99-8600-16280AC9397A@neville-neil.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 20 Aug 2015, at 13:13 , George Neville-Neil <gnn@neville-neil.com> = wrote: >=20 > Why was this work not in Phabricator? This is a large change that has = not been reviewed, > as far as I can tell, by anyone else on the project. I am tempted to = ask that this be backed out > and reviewed BEFORE it goes into the tree. I probably wouldn=E2=80=99t go as far as backing out. Given this seems part of a larger change that seem to be streamed into = HEAD and I have probably missed a posting or heads up or something on = net@ [if someone could point me at that it would be very helpful], I = appreciate things being broken into smaller reviewable bits. I have no = clear idea of what the end goal is or will be or look like, which makes = it hard to comment on design decisions. I however, as I have stated in the past, would really really appreciate = each change in PB, with the proposed commit message, and allow a few = days of review or for people to comment on. I have spend two years on = fixing bugs on the previous rewrite of that code. I am not exactly = looking forward to see history repeat itself. Thanks, Bjoern
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F83673EF-7327-4A3B-87DB-1DF7393D94E7>