Date: Wed, 2 Mar 2011 14:49:22 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Alexander Leidinger <netchild@freebsd.org> Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r219173 - in stable/8/sys: compat/linux kern Message-ID: <20110302124922.GZ78089@deviant.kiev.zoral.com.ua> In-Reply-To: <201103020953.p229rD4L090286@svn.freebsd.org> References: <201103020953.p229rD4L090286@svn.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Mar 02, 2011 at 09:53:13AM +0000, Alexander Leidinger wrote: > Author: netchild > Date: Wed Mar 2 09:53:13 2011 > New Revision: 219173 > URL: http://svn.freebsd.org/changeset/base/219173 > > Log: > MFC r215664: > By using the 32-bit Linux version of Sun's Java Development Kit 1.6 > on FreeBSD (amd64), invocations of "javac" (or "java") eventually > end with the output of "Killed" and exit code 137. > > This is caused by: > 1. After calling exec() in multithreaded linux program threads are not > destroyed and continue running. They get killed after program being > executed finishes. > > 2. linux_exit_group doesn't return correct exit code when called not > from group leader. Which happens regularly using sun jvm. > > The submitters fix this in a similar way to how NetBSD handles this. > > I took the PRs away from dchagin, who seems to be out of touch of > this since a while (no response from him). > > The patches committed here are from [2], with some little modifications > from me to the style. > > PR: 141439 [1], 144194 [2] > Submitted by: Stefan Schmidt <stefan.schmidt@stadtbuch.de>, gk > Reviewed by: rdivacky (in april 2010) > > MFC r215675: > Do not take the process lock. The assignment to u_short inside the > properly aligned structure is atomic on all supported architectures, and > the thread that should see side-effect of assignment is the same thread > that does assignment. > > Use a more appropriate conditional to detect the linux ABI. > > Suggested by: kib See r215706, that was a followup to the commit. Without it, stable/8 is broken: /usr/bsd/src/sys/modules/linux/../../compat/linux/linux_emul.c: In function 'linux_proc_exec': /usr/bsd/src/sys/modules/linux/../../compat/linux/linux_emul.c:265: error: dereferencing pointer to incomplete type /usr/bsd/src/sys/modules/linux/../../compat/linux/linux_emul.c:265: error: 'SV_ABI_MASK' undeclared (first use in this function) [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk1uPNIACgkQC3+MBN1Mb4hUAwCgpOVoaKNH+jBLgKTTll2gG5wz VR4AoK2hSX7D6mOpWQL7+G1cwU36i/Jc =Kipt -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110302124922.GZ78089>