Date: Mon, 8 Jul 2019 07:35:35 -0700 From: Enji Cooper <yaneurabeya@gmail.com> To: Hans Petter Selasky <hps@selasky.org> Cc: gljennjohn@gmail.com, sgk@troutmask.apl.washington.edu, Ian Lepore <ian@freebsd.org>, freebsd-current@freebsd.org, takawata@freebsd.org Subject: Re: Someone broke USB Message-ID: <35485A3A-B0C7-4D1B-AAB0-9B27E34D3894@gmail.com> In-Reply-To: <cceab398-ab4f-6271-8e84-0b6a5278ef04@selasky.org> References: <20190706231453.GA46470@troutmask.apl.washington.edu> <20190707080510.GA48223@troutmask.apl.washington.edu> <ff363616-37e2-8a90-7b3a-9eb18c51ba82@selasky.org> <20190707165429.GA50543@troutmask.apl.washington.edu> <025dfdc1-b2d2-ef88-c2d6-32d8f3620a9d@selasky.org> <99a61cc8-495f-a333-b4bc-46fc929bae37@selasky.org> <20190707185818.GA51398@troutmask.apl.washington.edu> <20ee6a81-d513-8332-8e47-6676dbb9a159@selasky.org> <20190707203635.GA53065@troutmask.apl.washington.edu> <2ccb6b71-022d-5b66-3ba9-007e2647b3e2@selasky.org> <20190707222555.GA55146@troutmask.apl.washington.edu> <602f5c9b-e15e-d08f-f388-47fc0a560803@selasky.org> <20190708120654.2599a06f@ernst.home> <cceab398-ab4f-6271-8e84-0b6a5278ef04@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jul 8, 2019, at 03:16, Hans Petter Selasky <hps@selasky.org> wrote: >=20 >> On 2019-07-08 12:06, Gary Jennejohn wrote: >> On Mon, 8 Jul 2019 11:50:31 +0200 >> Hans Petter Selasky <hps@selasky.org> wrote: >>> Hi Steve, >>>=20 >>> Can you test this patch? >>>=20 >>> I made a slight variant which delay the explore threads instead of the m= ain thread running all the sysinits. >>>=20 >> Shouldn't the patch set bus->explore_delay to 1 only if ms !=3D 0? >=20 > I think it doesn't matter. The code is only supposed to be run once. I think what Gary was referring to was that the patch only runs if the delay= value is =3D=3D 0. This seems like a logic [inversion] error to me. Thanks, -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35485A3A-B0C7-4D1B-AAB0-9B27E34D3894>