Date: Sat, 20 Feb 2016 10:13:58 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Andriy Voskoboinyk <s3erios@gmail.com> Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: software scan fix - please test (Was: why we can't use the net80211 taskqueue for everything) Message-ID: <CAJ-Vmo=tSCDsFtPkN5BMHzX5GPJSfZz-GMSZpFNq82FcWpf5VA@mail.gmail.com> In-Reply-To: <op.yc4mcrg5iew4ia@localhost> References: <CAJ-VmoneUBz4Vt3hFj8S4G_o8ptd3Z-NL5%2B6HuG33C3C_x-2jQ@mail.gmail.com> <op.yc4mcrg5iew4ia@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
hi! Please do test this patch out! This unblocks a whole lot of tidying up and restructuring of the wifi drivers to make them more predictable! -a On 20 February 2016 at 02:06, Andriy Voskoboinyk <s3erios@gmail.com> wrote: >> hi, >> >> andriy has a few reviews out that tidy up some things, which I'd reply >> to, but .. reviews is offline. So, here's the 30 second version: >> >> * the net80211 taskqueue runs the software scan engine, and the >> software scan engine currently sleeps whilst it's running. >> >> This means that if you put newstate, deferred transmit, etc into the >> net80211 taskqueue, then it just won't run during scan. >> >> The net80211 software scan thing should be modified to not sleep >> whilst it's waiting for scan results and instead just kick off another >> timer event to finish that part of the loop. Then yes, we can just >> migrate * to the net80211 task queue and use it for all serialisation >> of a wifi driver. >> >> (And yes, I'd like to see that done ASAP..) >> >> Thanks, >> >> >> -adrian > > > Hi, > > I have replaced sleeping on conditional variable inside scan task > with scan_curchan task rescheduling (so this problem should be fixed now). > > For everyone, who wishes to test: apply the attached patch > (merged from D5133, D5137, D5139, D5140, D5142, D5143, D5145, D5147, D5148 > and D5152) > and rebuild + install the kernel. Scan should work as before. > > Thanks!
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=tSCDsFtPkN5BMHzX5GPJSfZz-GMSZpFNq82FcWpf5VA>