Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 2 Apr 2025 20:48:24 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        Olivier Certner <olce@freebsd.org>, Mitchell Horne <mhorne@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: e69623451ea6 - main - mccomphy: add support for YT8531
Message-ID:  <97BD6C92-2FE2-4630-A137-AFBB156D54B5@freebsd.org>
In-Reply-To: <20250402194328.8A364214@slippy.cwsent.com>
References:  <202504021657.532Gv93w049180@gitrepo.freebsd.org> <2992932.slGk94SIus@ravel> <20250402194328.8A364214@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Apr 2025, at 20:43, Cy Schubert <Cy.Schubert@cschubert.com> wrote:
>=20
> In message <2992932.slGk94SIus@ravel>, Olivier Certner writes:
>>=20
>> Hi Mitchell,
>>=20
>> This commit is likely the cause of the current build failure on =
amd64, see:
>> https://ci.freebsd.org/job/FreeBSD-main-amd64-build/31518/
>>=20
>> Thanks and regards.
>>=20
>> --=20
>> Olivier Certner
>=20
> Hmm. I wonder why this was committed in the first place. The review =
listed=20
> isn't this commit.
>=20
> Should this be reverted to a) correct the commit log message to =
document=20
> the correct revision and b) fix the build?

The review was split into multiple commits and Phabricator
automatically updated it to match the changes from a single one of the
commits. https://reviews.freebsd.org/D45600?id=3D139913 is an earlier
version that included these changes.

Jess




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97BD6C92-2FE2-4630-A137-AFBB156D54B5>