Date: Sun, 15 Aug 2010 20:57:24 +0100 From: Bruce Cran <bruce@cran.org.uk> To: Dag-Erling Smorgrav <des@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211304 - head/lib/libutil Message-ID: <20100815205724.00007e0f@unknown> In-Reply-To: <201008141434.o7EEYaSA030301@svn.freebsd.org> References: <201008141434.o7EEYaSA030301@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 14 Aug 2010 14:34:36 +0000 (UTC) Dag-Erling Smorgrav <des@FreeBSD.org> wrote: > Author: des > Date: Sat Aug 14 14:34:36 2010 > New Revision: 211304 > URL: http://svn.freebsd.org/changeset/base/211304 > > Log: > Simplify expand_number() by combining the (unrolled) loop with the > switch. Since expand_number() does not accept negative numbers, > switch from int64_t to uint64_t; this makes it easier to check for > overflow. > MFC after: 3 weeks Somewhat related, there are overflow bugs in humanize_number - for example df(1) fails to display space from a 100PB filesystem correctly. -- Bruce Cran
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100815205724.00007e0f>