Date: Tue, 08 Oct 2024 20:40:45 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: c2d93a803ace - main - env: Check the status of stdout. Message-ID: <86iku2v3o2.fsf@ltc.des.dev> In-Reply-To: <ZwVuwK9Lry_6JDay@kib.kiev.ua> (Konstantin Belousov's message of "Tue, 8 Oct 2024 20:41:20 %2B0300") References: <202410081702.498H2KIP072012@gitrepo.freebsd.org> <ZwVuwK9Lry_6JDay@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov <kostikbel@gmail.com> writes: > Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> writes: > > + if (fflush(stdout) !=3D 0) > > + err(1, "stdout"); > Why is this check needed? POSIX requires it. > Or, put it differently, why is it needed for env(1) but not any other > program that writes to stdout? You mean like these? % git -P grep -l 'err\(1, "stdout"\)' bin/cat/cat.c bin/date/date.c sbin/md5/md5.c usr.bin/asa/asa.c usr.bin/comm/comm.c usr.bin/ctags/ctags.c usr.bin/du/du.c usr.bin/env/env.c usr.bin/head/head.c usr.bin/join/join.c usr.bin/lastcomm/lastcomm.c usr.bin/locate/code/locate.code.c usr.bin/ncal/ncal.c usr.bin/sed/main.c usr.bin/tail/misc.c usr.bin/tsort/tsort.c usr.bin/w/w.c usr.bin/yes/yes.c or these? https://reviews.freebsd.org/D41390 https://reviews.freebsd.org/D41408 https://reviews.freebsd.org/D41413 https://reviews.freebsd.org/D41414 https://reviews.freebsd.org/D41417 https://reviews.freebsd.org/D41418 https://reviews.freebsd.org/D41422 https://reviews.freebsd.org/D41423 https://reviews.freebsd.org/D41424 https://reviews.freebsd.org/D41427 https://reviews.freebsd.org/D41428 https://reviews.freebsd.org/D41432 DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86iku2v3o2.fsf>