Date: Tue, 20 Dec 2011 11:25:49 -0800 From: Jason Helfman <jgh@FreeBSD.org> To: Greg Lewis <glewis@eyesbeyond.com> Cc: freebsd-java@FreeBSD.org Subject: Re: java/163456: [patch] java/openjdk6: build and distribute open timezone data (tzdata) Message-ID: <20111220192549.GA58911@dormouse.experts-exchange.com> In-Reply-To: <201112201750.pBKHoD7P060916@freefall.freebsd.org> References: <201112201750.pBKHoD7P060916@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tue, Dec 20, 2011 at 05:50:13PM +0000, Greg Lewis thus spake:
> Thanks for doing this! I wonder if with a little more work we couldn't
> make this work for all of the JDK ports instead of having to reimplement
> it for openjdk7, jdk16, jdk15, diablo, etc.
Yeah, I suppose this could be done, and sounds fitting. I haven't researched
it enough for all jdk implementations, however it going into openjdk{6,7}, at
a minimum is a good start, in my opinion, until a more lucrative method is
found. I couldn't believe that the timezone data hasn't been updated in
openjdk6 since 2010, and I believe supplying at least updated zoneinfo is
something we should consider.
> I.e., can we pull this out into a separate port that installs the
> appropriate zoneinfo files into somewhere like
> ${LOCALBASE}/share/java/zoneinfo and then symlink the zi directory in all
> of the jdk and jre ports to that directory.
Installation of the zoneinfo files isn't the key, though. It is the raw
timezone files that are required so java can build against them. But if
those were built against then installed for java, that could work.
>
> I haven't looked deeply into your change but I assume the biggest problem
> with this is that you need a JDK with javazic.jar already installed before
> you can process the raw zoneinfo files so we'd be creating a circular
> dependency.
You don't need it installed. You can use the tool at build-time. My patch
uses the ${WRKSRC} built bin/java and javazic.jar tool to build the zone
files. It puts them into their new working directory, and they are installed
with the install target.
Hope this explains things a little more clearly.
- -jgh
- --
Jason Helfman | FreeBSD Committer
jgh@FreeBSD.org | http://people.freebsd.org/~jgh
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)
iQEcBAEBAgAGBQJO8OE9AAoJECBZmmNBUNPcSucH+gNbdBWQ9qpQTryvt2N4+Cqv
ZSFjgZRaDcYUtNH2SNUS+aK8qTGWy6d/fKtkREZwe/2OS8AT8Ptg+2qSkRS/d+P2
ymKPvqzxBnU8QjZSGqW2bHckWR01UUkpFo23RD66wk/KvcfOTYQlMMHCVKpI5mVG
kNbYH4r9wFEjkzS0TNboGiDOZ8kZEmWwnyGGQqIjYZM2MKc5SsnRhaW2WYwYGuEH
O65y/ePjr4QAY6WLVFYijYEiguieErJWu514KqRQiB7QVoc9aBcaXzMUW9mzSpjg
Cnk2iqBfdCmUZ7r3WBa3cKRjYWtOKlR/6JUlqKTUA662BWV7tlEDoXhml/VjxoI=
=3UgU
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111220192549.GA58911>