Date: Thu, 29 Apr 2010 09:56:44 +0300 From: Mikolaj Golub <to.my.trociny@gmail.com> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-fs <freebsd-fs@freebsd.org> Subject: Re: hastd segfaults reading metadata from not initialized provider Message-ID: <86r5lykaqb.fsf@zhuzha.ua1> In-Reply-To: <20100428224326.GE1677@garage.freebsd.pl> (Pawel Jakub Dawidek's message of "Thu, 29 Apr 2010 00:43:26 %2B0200") References: <86iq7ex9j0.fsf@kopusha.onet> <20100428224326.GE1677@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 29 Apr 2010 00:43:26 +0200 Pawel Jakub Dawidek wrote: PJD> On Mon, Apr 26, 2010 at 11:07:31PM +0300, Mikolaj Golub wrote: >> Hi, >> >> When configuring a new provider if one forgets to do >> >> hastctl create tank >> >> before >> >> hastctl role primary tank PJD> In my tests I cannot reproduce it. If metadata is empty hastd should PJD> notice that, but check for NULL was missing anyway. I observe this on VirtualBox hosts with virtual disks (dynamically expanding storage). PJD> I fixed it a bit different. In general nv API is constructued in a way PJD> that the consumer might execute various calls and check for error at the PJD> end. This is what we do there already, only (str != NULL) check was PJD> missing. Thanks for the report, I committed fix to HEAD. Thank you :-) -- Mikolaj Golub
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86r5lykaqb.fsf>