Date: Tue, 2 Dec 2025 22:26:33 -0700 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Minsoo Choo <minsoochoo0122@proton.me> Subject: Re: git: f42421307b11 - main - sys: remove armv6/6.1 support from debug monitor Message-ID: <CANCZdfr4tDHWoho7THjNap2H4zsqsa6bt44UdRUXTeC4_onxGw@mail.gmail.com> In-Reply-To: <d8a3ba7d-354b-4fb7-84cb-14d82ef5e392@FreeBSD.org> References: <692a8ea7.feb1.63d10382@gitrepo.freebsd.org> <d8a3ba7d-354b-4fb7-84cb-14d82ef5e392@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Dec 1, 2025 at 8:18 AM John Baldwin <jhb@freebsd.org> wrote: > On 11/29/25 01:11, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=f42421307b115345ea1a6c8fdf61fbb581e4400f > > > > commit f42421307b115345ea1a6c8fdf61fbb581e4400f > > Author: Minsoo Choo <minsoochoo0122@proton.me> > > AuthorDate: 2025-11-29 00:34:40 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2025-11-29 04:56:36 +0000 > > > > sys: remove armv6/6.1 support from debug monitor > > > > Signed-off-by: Minsoo Choo <minsoochoo0122@proton.me> > > Reviewed by: imp > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1903 > > --- > > sys/arm/arm/debug_monitor.c | 30 ------------------------------ > > 1 file changed, 30 deletions(-) > > > > diff --git a/sys/arm/arm/debug_monitor.c b/sys/arm/arm/debug_monitor.c > > index 7944becbae4d..4d61896a2142 100644 > > --- a/sys/arm/arm/debug_monitor.c > > +++ b/sys/arm/arm/debug_monitor.c > > @@ -83,8 +83,6 @@ static uint32_t dbg_breakpoint_num; > > #define ID_DFR0_CP_DEBUG_M_SHIFT 0 > > #define ID_DFR0_CP_DEBUG_M_MASK (0xF << > ID_DFR0_CP_DEBUG_M_SHIFT) > > #define ID_DFR0_CP_DEBUG_M_NS (0x0) /* Not supported */ > > -#define ID_DFR0_CP_DEBUG_M_V6 (0x2) /* v6 Debug arch. > CP14 access */ > > -#define ID_DFR0_CP_DEBUG_M_V6_1 (0x3) /* v6.1 Debug arch. > CP14 access */ > > #define ID_DFR0_CP_DEBUG_M_V7 (0x4) /* v7 Debug arch. > CP14 access */ > > #define ID_DFR0_CP_DEBUG_M_V7_1 (0x5) /* v7.1 Debug arch. > CP14 access */ > > Humm, I would have probably left these as the register is still valid and > I find it > useful to describe the full range of values for registers that we define > constants for. > The rest of the removal certainly makes sense. > Sure. > > > > @@ -594,10 +592,6 @@ dbg_enable_monitor(void) > > dbg_dscr = cp14_dbgdscrint_get(); > > > > switch (dbg_model) { > > - case ID_DFR0_CP_DEBUG_M_V6: > > - case ID_DFR0_CP_DEBUG_M_V6_1: /* fall through */ > > - cp14_dbgdscr_v6_set(dbg_dscr | DBGSCR_MDBG_EN); > > - break; > > Should this function also be removed? Looks to be defined here in > sys/arm/include/cpu.h: > > _WF1(cp14_dbgdscr_v6_set, CP14_DBGDSCRext_V6(%0)) > OK. I'll do these tweaks.. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Mon, Dec 1, 2025 at 8:18 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 11/29/25 01:11, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=f42421307b115345ea1a6c8fdf61fbb581e4400f" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=f42421307b115345ea1a6c8fdf61fbb581e4400f</a><br>; > <br> > commit f42421307b115345ea1a6c8fdf61fbb581e4400f<br> > Author: Minsoo Choo <<a href="mailto:minsoochoo0122@proton.me" target="_blank">minsoochoo0122@proton.me</a>><br> > AuthorDate: 2025-11-29 00:34:40 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2025-11-29 04:56:36 +0000<br> > <br> > sys: remove armv6/6.1 support from debug monitor<br> > <br> > Signed-off-by: Minsoo Choo <<a href="mailto:minsoochoo0122@proton.me" target="_blank">minsoochoo0122@proton.me</a>><br> > Reviewed by: imp<br> > Pull Request: <a href="https://github.com/freebsd/freebsd-src/pull/1903" rel="noreferrer" target="_blank">https://github.com/freebsd/freebsd-src/pull/1903</a><br>; > ---<br> > sys/arm/arm/debug_monitor.c | 30 ------------------------------<br> > 1 file changed, 30 deletions(-)<br> > <br> > diff --git a/sys/arm/arm/debug_monitor.c b/sys/arm/arm/debug_monitor.c<br> > index 7944becbae4d..4d61896a2142 100644<br> > --- a/sys/arm/arm/debug_monitor.c<br> > +++ b/sys/arm/arm/debug_monitor.c<br> > @@ -83,8 +83,6 @@ static uint32_t dbg_breakpoint_num;<br> > #define ID_DFR0_CP_DEBUG_M_SHIFT 0<br> > #define ID_DFR0_CP_DEBUG_M_MASK (0xF << ID_DFR0_CP_DEBUG_M_SHIFT)<br> > #define ID_DFR0_CP_DEBUG_M_NS (0x0) /* Not supported */<br> > -#define ID_DFR0_CP_DEBUG_M_V6 (0x2) /* v6 Debug arch. CP14 access */<br> > -#define ID_DFR0_CP_DEBUG_M_V6_1 (0x3) /* v6.1 Debug arch. CP14 access */<br> > #define ID_DFR0_CP_DEBUG_M_V7 (0x4) /* v7 Debug arch. CP14 access */<br> > #define ID_DFR0_CP_DEBUG_M_V7_1 (0x5) /* v7.1 Debug arch. CP14 access */<br> <br> Humm, I would have probably left these as the register is still valid and I find it<br> useful to describe the full range of values for registers that we define constants for.<br> The rest of the removal certainly makes sense.<br></blockquote><div><br></div><div>Sure.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > <br> > @@ -594,10 +592,6 @@ dbg_enable_monitor(void)<br> > dbg_dscr = cp14_dbgdscrint_get();<br> > <br> > switch (dbg_model) {<br> > - case ID_DFR0_CP_DEBUG_M_V6:<br> > - case ID_DFR0_CP_DEBUG_M_V6_1: /* fall through */<br> > - cp14_dbgdscr_v6_set(dbg_dscr | DBGSCR_MDBG_EN);<br> > - break;<br> <br> Should this function also be removed? Looks to be defined here in sys/arm/include/cpu.h:<br> <br> _WF1(cp14_dbgdscr_v6_set, CP14_DBGDSCRext_V6(%0))<br></blockquote><div><br></div><div>OK. I'll do these tweaks..</div><div><br></div><div>Warner</div><div> </div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfr4tDHWoho7THjNap2H4zsqsa6bt44UdRUXTeC4_onxGw>