Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Apr 2017 13:52:16 +0200
From:      Ed Schouten <ed@nuxi.nl>
To:        "Andrey V. Elsukov" <ae@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r316825 - head/sys/netpfil/ipfw
Message-ID:  <CABh_MKn%2BCZ=xfQJP4UKfQjQCMNVzGw0tAS99RLZRYS5X14B3pg@mail.gmail.com>
In-Reply-To: <201704141141.v3EBf9MC097085@repo.freebsd.org>
References:  <201704141141.v3EBf9MC097085@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi there,

2017-04-14 13:41 GMT+02:00 Andrey V. Elsukov <ae@freebsd.org>:
> -               memcpy(&tent->k, &xn->addr6.sin6_addr, sizeof(struct in6_addr));
> +               memcpy(&tent->k.addr6, &xn->addr6.sin6_addr,
> +                   sizeof(struct in6_addr));

In this case the code could be abbreviated by simply using assignment, right?

tent->k.addr6 = xn->addr6.sin6_addr;

-- 
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKn%2BCZ=xfQJP4UKfQjQCMNVzGw0tAS99RLZRYS5X14B3pg>