Date: Tue, 22 Nov 2011 18:26:24 +0000 From: "Paul B. Mahol" <onemda@gmail.com> To: Kostik Belousov <kostikbel@gmail.com> Cc: net <net@freebsd.org> Subject: Re: [PATCH] ndis: safe fpu on amd64 Message-ID: <CAPYw7P45=HR9TRXbXgjHi5SzTQwsA=TyyDqbz6KEtYbCerp1Ow@mail.gmail.com> In-Reply-To: <20111122093357.GJ50300@deviant.kiev.zoral.com.ua> References: <CAPYw7P6eNFwFJn=7922hCD3Ajtjmtyp388onSyanUOCG=rQH8Q@mail.gmail.com> <20111122093357.GJ50300@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/22/11, Kostik Belousov <kostikbel@gmail.com> wrote: > On Mon, Nov 21, 2011 at 03:49:16PM +0000, Paul B. Mahol wrote: >> Hi, >> >> This patch should fix panic on amd64 when using ndis with drivers >> which make use of fpu registers. > Do not allocate fpu_kern_ctx on stack. Its size is 528 bytes on amd64 right > now, and potentially can grow after AVX support is finished. So I need to introduce locks and allocate fpu_kern_ctx per CPU because otherwise memory leaks are possible.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPYw7P45=HR9TRXbXgjHi5SzTQwsA=TyyDqbz6KEtYbCerp1Ow>