Date: Thu, 18 May 2017 02:56:31 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Ngie Cooper <ngie@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r318441 - in head/etc: . cron.d Message-ID: <201705180956.v4I9uVpQ065465@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201705180625.v4I6Pd9j062495@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: ngie > Date: Thu May 18 06:25:39 2017 > New Revision: 318441 > URL: https://svnweb.freebsd.org/changeset/base/318441 > > Log: > Handle the cron.d entry for MK_AT in cron conditionally > > Install /etc/cron.d/at if MK_AT != no, always using it, which tries > to run a non-existent program via cron(8) every 5 minutes with the > default /etc/crontab, prior to this commit. > > SHELL and PATH are duplicated between /etc/crontab and /etc/cron.d/at > because atrun(8) executes programs, which may rely on environment > currently set via /etc/crontab. > > Noted by: bdrewery (in an internal review) > MFC after: 2 months > Relnotes: yes (may need to add environmental modifications to > /etc/cron.d/at) > Sponsored by: Dell EMC Isilon > > Added: > head/etc/cron.d/ > head/etc/cron.d/Makefile (contents, props changed) > head/etc/cron.d/at (contents, props changed) > Modified: > head/etc/Makefile > head/etc/crontab > > Modified: head/etc/Makefile > ============================================================================== > --- head/etc/Makefile Thu May 18 06:15:42 2017 (r318440) > +++ head/etc/Makefile Thu May 18 06:25:39 2017 (r318441) > @@ -8,6 +8,7 @@ FILESGROUPS= FILES > # No need as it is empty and just causes rebuilds since this file does so much. > UPDATE_DEPENDFILE= no > SUBDIR= \ > + cron.d \ > newsyslog.conf.d \ > syslog.d The thread on the newsyslog clearly shows that this is a contriversial change. I strongly object to further splitting of /etc/FOO into /etc/foo.d/FOO files to suite Dell/EMC/Isilon's needs. It is in conflict with the needs and desires of others. I especially object to it being done on a 1 of case, either completly split the file or make it 1 file, but making it this miss match is just adding to the work load of ansible and puppet task writting. You now have to mange 2 config files rather than 1 for cron, and 7 for newsyslog instead of 1. > Added: head/etc/cron.d/Makefile > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/etc/cron.d/Makefile Thu May 18 06:25:39 2017 (r318441) > @@ -0,0 +1,11 @@ > +# $FreeBSD$ > + > +.include <src.opts.mk> > + > +.if ${MK_AT} != "no" > +FILES+= at > +.endif > + > +BINDIR= /etc/cron.d > + > +.include <bsd.prog.mk> > > Added: head/etc/cron.d/at > ============================================================================== > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > +++ head/etc/cron.d/at Thu May 18 06:25:39 2017 (r318441) > @@ -0,0 +1,7 @@ > +# $FreeBSD$ > +# > +SHELL=/bin/sh > +PATH=/etc:/bin:/sbin:/usr/bin:/usr/sbin > + > +# See crontab(5) for field format. > +*/5 * * * * root /usr/libexec/atrun > > Modified: head/etc/crontab > ============================================================================== > --- head/etc/crontab Thu May 18 06:15:42 2017 (r318440) > +++ head/etc/crontab Thu May 18 06:25:39 2017 (r318441) > @@ -7,8 +7,6 @@ PATH=/etc:/bin:/sbin:/usr/bin:/usr/sbin > # > #minute hour mday month wday who command > # > -*/5 * * * * root /usr/libexec/atrun > -# > # Save some entropy so that /dev/random can re-seed on boot. > */11 * * * * operator /usr/libexec/save-entropy > # > > -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201705180956.v4I9uVpQ065465>