Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Feb 2005 12:02:35 -0800
From:      Nate Lawson <nate@root.org>
To:        "Alexandre \"Sunny\" Kovalenko" <Alex.Kovalenko@verizon.net>
Cc:        freebsd-acpi@freebsd.org
Subject:   Re: Thermal state switching
Message-ID:  <420FB25B.8010106@root.org>
In-Reply-To: <1107914318.1015.15.camel@RabbitsDen>
References:  <1107914318.1015.15.camel@RabbitsDen>

next in thread | previous in thread | raw e-mail | index | archive | help
Alexandre "Sunny" Kovalenko wrote:
> Good people,
> 
> I was looking at thermal states switching by acpi_thermal.c and it looks
> like follows (provided that temperature raises and falls slowly and
> gradually):
> 
> NONE =up> AC2 =up> AC1 =up> AC0 =down> NONE                       (1)
> 
> I do not know whether this was intentional or not and, for me, something
> along the lines of
> 
> NONE =up> AC2 =up> AC1 =up> AC0 =down> AC1 =down> AC2 =down> NONE (2)
> 
> seemed more natural.
> 
> If (2) and not (1) was indeed the desired behavior attached patch seems
> to do the job. If (1) is what was intended, I do apologize for the
> noise.
> 
> I am running -CURRENT from February 3.

The behavior should be as in #2.  If it isn't, we should fix that. 
However, I'm not sure how your patch would fix this.  It seems more 
correct in that we only set the starting time after switching coolers 
but I don't see how this affects the ACx levels.  Could you explain more?

Thanks,
-- 
Nate



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?420FB25B.8010106>