Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Dec 2018 13:29:17 +0000 (UTC)
From:      Slava Shwartsman <slavash@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r341542 - head/sys/dev/mlx4/mlx4_core
Message-ID:  <201812051329.wB5DTHNm070820@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: slavash
Date: Wed Dec  5 13:29:16 2018
New Revision: 341542
URL: https://svnweb.freebsd.org/changeset/base/341542

Log:
  mlx4core: Avoid multiplication overflow by casting multiplication.
  
  Submitted by:   hselasky@
  Approved by:    hselasky (mentor)
  MFC after:      1 week
  Sponsored by:   Mellanox Technologies

Modified:
  head/sys/dev/mlx4/mlx4_core/mlx4_icm.c

Modified: head/sys/dev/mlx4/mlx4_core/mlx4_icm.c
==============================================================================
--- head/sys/dev/mlx4/mlx4_core/mlx4_icm.c	Wed Dec  5 13:28:46 2018	(r341541)
+++ head/sys/dev/mlx4/mlx4_core/mlx4_icm.c	Wed Dec  5 13:29:16 2018	(r341542)
@@ -411,7 +411,7 @@ int mlx4_init_icm_table(struct mlx4_dev *dev, struct m
 	size = (u64) nobj * obj_size;
 	for (i = 0; i * MLX4_TABLE_CHUNK_SIZE < reserved * obj_size; ++i) {
 		chunk_size = MLX4_TABLE_CHUNK_SIZE;
-		if ((i + 1) * MLX4_TABLE_CHUNK_SIZE > size)
+		if ((u64) (i + 1) * MLX4_TABLE_CHUNK_SIZE > size)
 			chunk_size = PAGE_ALIGN(size -
 					i * MLX4_TABLE_CHUNK_SIZE);
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201812051329.wB5DTHNm070820>