Date: Thu, 5 Sep 2013 16:46:48 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, Jilles Tjoelker <jilles@stack.nl>, Peter Wemm <peter@freebsd.org>, svn-src-all@freebsd.org, Dimitry Andric <dim@freebsd.org>, Joel Dahl <joel@vnode.se>, gabor@freebsd.org, svn-src-head@freebsd.org, Peter Wemm <peter@wemm.org> Subject: Re: svn commit: r254273 - in head: . include lib lib/libc/iconv lib/libiconv_compat lib/libkiconv share/mk sys/sys tools/build/mk Message-ID: <20130905144647.GO82066@ithaqua.etoilebsd.net> In-Reply-To: <201309051013.35286.jhb@freebsd.org> References: <201308130715.r7D7F1nu076335@svn.freebsd.org> <20130822155835.GA52789@devbox.vnode.local> <20130903195241.GA93218@devbox.vnode.local> <201309051013.35286.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Qa0ccP92Gc0Ko3P8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 05, 2013 at 10:13:34AM -0400, John Baldwin wrote: > On Tuesday, September 03, 2013 3:52:41 pm Joel Dahl wrote: > > On Thu, Aug 22, 2013 at 05:58:35PM +0200, Joel Dahl wrote: > > > On Sun, Aug 18, 2013 at 03:51:25PM -0700, Peter Wemm wrote: > > > > On 8/18/13 3:42 PM, Jilles Tjoelker wrote: > > > > > On Sun, Aug 18, 2013 at 09:53:04PM +0200, Joel Dahl wrote: > > > > >> On Sun, Aug 18, 2013 at 12:34:30AM +0200, Dimitry Andric wrote: > > > > >>> On Aug 13, 2013, at 09:15, Peter Wemm <peter@FreeBSD.org> wrote: > > > > >>>> Author: peter > > > > >>>> Date: Tue Aug 13 07:15:01 2013 > > > > >>>> New Revision: 254273 > > > > >>>> URL: http://svnweb.freebsd.org/changeset/base/254273 > > > > >=20 > > > > >>>> Log: > > > > >>>> The iconv in libc did two things - implement the standard API= s, the GNU > > > > >>>> extensions and also tried to be link time compatible with por= ts libiconv. > > > > >>>> This splits that functionality and enables the parts that sho= uldn't > > > > >>>> interfere with the port by default. > > > > >=20 > > > > >>>> WITH_ICONV (now on by default) - adds iconv.h, iconv_open(3) = etc. > > > > >>>> WITH_LIBICONV_COMPAT (off by default) adds the libiconv_open = etc API, linker > > > > >>>> symbols and even a stub libiconv.so.3 that are good enough to= be able > > > > >>>> to 'pkg delete -f libiconv' on a running system and reasonabl= y expect it > > > > >>>> to work. > > > > >=20 > > > > >>>> I have tortured many machines over the last few days to try a= nd reduce > > > > >>>> the possibilities of foot-shooting as much as I can. I've su= ccessfully > > > > >>>> recompiled to enable and disable the libiconv_compat modes, p= orts that use > > > > >>>> libiconv alongside system iconv etc. If you don't enable the > > > > >>>> WITH_LIBICONV_COMPAT switch, they don't share symbol space. > > > > >=20 > > > > >>>> This is an extension of behavior on other system. iconv(3) i= s a standard > > > > >>>> libc interface and libiconv port expects to be able to run al= ongside it on > > > > >>>> systems that have it. > > > > >=20 > > > > >>> Unfortunately I expect this will break many ports, when the lib= iconv > > > > >>> port is installed. A simple example is the following: > > > > >> <SNIP> > > > > >=20 > > > > >> It also breaks installworld when /usr/src and /usr/obj are NFS e= xported > > > > >> read-only. > > > > >=20 > > > > > I think it has to do with share/i18n/csmapper and share/i18n/esdb= using > > > > > directories as make targets. This apparently causes these files t= o be > > > > > rebuilt at 'make installworld' time, which is always bad but is o= nly > > > > > detected when /usr/obj is read-only. > > > > >=20 > > > > > A hack that works is to enclose the four targets depending on ${S= UBDIR} > > > > > in .if !make(install) . > > > > >=20 > > > > > Unfortunately, the Makefiles were written to depend on the direct= ories > > > > > as make targets fairly deeply, so a real fix is harder. > > > >=20 > > > > I was looking at this yesterday, but was tied up with other things.= I'll > > > > take a look at it today after getting a few other things done. It = should be > > > > easy enough to replicate by changing /usr/obj to readonly on test s= ystems. > > >=20 > > > FWIW, this is still broken. > >=20 > > Again, this is still broken. >=20 > Yeah, my laptop failed to build cups (required by ghostscript which is re= quired > by emacs) because of this: >=20 > =3D=3D=3D> FreeBSD 10 autotools fix applied to /usr/ports/print/cups-im= age/work/cups-1.5.4/configure > Configuring CUPS with options: > ... > configure: WARNING: unrecognized options: --disable-pdftops > ... > checking iconv.h usability... yes > checking iconv.h presence... yes > checking for iconv.h... yes > checking for library containing iconv_open... none required > ... > Linking texttops... > cc -L../cgi-bin -L../cups -L../filter -L../ppdc -L../scheduler -L/usr/loc= al/lib -Wl,-rpath=3D/usr/lib:/usr/local/lib -Wl,-R/usr/local/lib -Wall -W= no- > format-y2k -Wunused -fPIC -Os -g -fstack-protector -Wno-tautological-comp= are -o texttops texttops.o textcommon.o common.o -lcups -lssl -lcrypto -l= z=20 > -pthread -lcrypt -lm -lssp_nonshared=20 > ../cups/libcups.so: undefined reference to `libiconv' > ../cups/libcups.so: undefined reference to `libiconv_close' > ../cups/libcups.so: undefined reference to `libiconv_open' > cc: error: linker command failed with exit code 1 (use -v to see invocati= on) > gmake[9]: *** [commandtops] Error 1 > ... >=20 > Having cups broken will probably break all of kde, etc. Are we seeing th= is > in HEAD package builds yet? (Maybe the world we are using doesn't have > this change yet?) Note that this is just a clean build of HEAD and a fre= sh > build of ports from scratch. >=20 This should work properly now, the ports tree received motification yesterd= ay and converters/libiconv is not installed anymore now. regards, Bapt --Qa0ccP92Gc0Ko3P8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlIomVcACgkQ8kTtMUmk6EwPOgCgj0LeXhe56NfFHtfP0acKhKjl 6OwAoJATDcqMXj5lkU71Rj5fiH5nL/iS =kP58 -----END PGP SIGNATURE----- --Qa0ccP92Gc0Ko3P8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130905144647.GO82066>