Date: Sat, 10 Aug 2002 10:06:58 -0400 From: Bosko Milekic <bmilekic@unixdaemons.com> To: Morten Rodal <morten@rodal.no> Cc: Eirik Nygaard <eirikn@bluezone.no>, current@FreeBSD.ORG Subject: Re: Rewrite of the perl script rmuser to C Message-ID: <20020810100658.A92716@unixdaemons.com> In-Reply-To: <20020810135941.GF6050@slurp.rodal.no>; from morten@rodal.no on Sat, Aug 10, 2002 at 03:59:42PM %2B0200 References: <20020810120239.GB1064@test.eirikn.net> <20020810135941.GF6050@slurp.rodal.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 10, 2002 at 03:59:42PM +0200, Morten Rodal wrote:
> On Sat, Aug 10, 2002 at 02:02:39PM +0200, Eirik Nygaard wrote:
> > I have just rewritten the rmuser perl script to C, it would be
> > great if you could take a look at it and check if everything is ok.
>
> You should probably replace the strcpy() and strcat() with strlcpy(3) and
> strlcat(3), or at least use the strncpy(3) and strncat(3). Also, sprintf()
> should be replaced with snprintf(3).
>
> Maybe close the file descriptors in the signal handlers?
Also, please clean it up, style-wise. I couldn't even read it due to
mis-aligned braces ( { and } ). Thanks.
--
Bosko Milekic * bmilekic@unixdaemons.com * bmilekic@FreeBSD.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020810100658.A92716>