Date: Thu, 6 Jan 2000 03:42:25 -0500 (EST) From: Brian Fundakowski Feldman <green@FreeBSD.org> To: Soren Schmidt <sos@freebsd.dk> Cc: current@FreeBSD.org Subject: Re: ATA atapi-all.c problems/fixes/cleanups Message-ID: <Pine.BSF.4.10.10001060338250.454-100000@green.dyndns.org> In-Reply-To: <200001060750.IAA73510@freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 6 Jan 2000, Soren Schmidt wrote:
> It seems Brian Fundakowski Feldman wrote:
> > How about this? It's mostly the changes in your patch, but it also takes
> > into account non-int{8,16}_t-sizing/alignment. It also takes care of the
> > truncation problem when you use outsl and insl, as part of that. Please
> > review it, as I think it should be the right thing to do.
>
> Hmm, sortof. In the real world we should newer ever see partial
> transfers, they should always be of N * DEV_BSIZE, so this is
> a bitt overkill. However some of the internal ATAPI handling
> use odd sizes for modes etc, but they are all at least 16 bit
> aligned, so 8 bit alignment is not needed, I'll have to check
> if we need 16 bit alignment, I can't remember ofhand...
It's just as well. It's almost 4 AM and I've just about given up on getting
this all working. Anyway, if everything has to be DEV_BSIZE, then I guess
that would simplify things, except when I try, say, writing 4697 bytes
as an audio blocksize (2 * 2352 - 7), it goes all the way through the
acdstrategy as 4697... I don't know why DEV_BSIZE isn't respected, then,
but I suppose Poul might be able to help here?
Anyway, for now, I'd just be satisfied with having atapi-all.c
corrected WRT the request->bytecount and length mixup. I've been working
on this for four hours, have no clue what I'm doing wrong, and have
school tomorrow.
>
> -Søren
>
--
Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! /
green@FreeBSD.org `------------------------------'
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.10001060338250.454-100000>