Date: Thu, 7 Jun 2007 09:04:55 +0200 From: Roman Divacky <rdivacky@FreeBSD.org> To: Doug Barton <dougb@FreeBSD.org> Cc: Eric Lemar <eric.lemar@isilon.com>, arch@FreeBSD.org Subject: Re: *at family of syscalls in FreeBSD Message-ID: <20070607070455.GA71012@freebsd.org> In-Reply-To: <4666F0FB.8020101@FreeBSD.org> References: <20070604162430.GA76813@freebsd.org> <896DB1FBFFD5A145833D9DA08CA12A85051A7F@seaxch07.desktop.isilon.com> <20070606074429.GA42032@freebsd.org> <4666F0FB.8020101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 06, 2007 at 10:38:03AM -0700, Doug Barton wrote: > Roman Divacky wrote: > > > my current patch is at: www.vlakno.cz/~rdivacky/linux_at.patch > > > > it does not implement the native fbsd syscalls, only the linuxulator ones > > but adding those is a matter of minutes. I asked for a review by pjd and/or > > rwatson and hopefully this will get commited soon.. > > My recollection of the last round of discussion was that you were > asked to implement these in our base, then wrap the linux versions. If > it's trivial to implement, it should probably be done that way first. well.. my implementation does exactly that :) I changed namei() routine to check ni_startdir for possible startdir other then CWD and made the kern_fooat() use it. the change is mostly self-contained (minus prototypes in sys/sys/syscallsubr.h) in vfs_syscalls. with a very slight change (5 lines?) to vfs_lookup.c + namei.h its quite simple. I cant comment the Isilon's version. My patch (the approach) has been OKed by rwatson@ and pjd@. I'd really love to see this go to -current before RELENG_7 so time is rushing. can someone from Isilon comment their version so we can compare benefits etc.? roman
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070607070455.GA71012>