Date: Thu, 3 Sep 2009 14:28:46 -0600 From: Scott Long <scottl@samsco.org> To: John Baldwin <jhb@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Alexander Motin <mav@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, Ivan Voras <ivoras@freebsd.org> Subject: Re: svn commit: r196777 - head/sys/dev/ahci Message-ID: <ED9A2CE6-59E0-458C-A5D3-3C4AD240659E@samsco.org> In-Reply-To: <200909031602.01222.jhb@freebsd.org> References: <200909031237.n83CbIgk032551@svn.freebsd.org> <20090903114121.C20031@pooker.samsco.org> <9bbcef730909031245o7c380925sd29b2cc976c4d7dd@mail.gmail.com> <200909031602.01222.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 3, 2009, at 2:02 PM, John Baldwin <jhb@freebsd.org> wrote: > On Thursday 03 September 2009 3:45:07 pm Ivan Voras wrote: >> But ciss doesn't reference it at all so either it deviously assumes >> it >> or is independent of it. > > Actually, it may be much worse, it may be that the author of ciss(4) > new that > ciss(4)'s largest supported I/O size was larger than 128k so they > didn't > bother handling the limit at all giving the false impression the > hardware has > no limit. You're exactly right. The solution is to do a proper audit and fix the potential problems, not add yet another 1-off flag that avoids doing real work. If you want to help, keep in mind that I need help _generating_ patches, not testing them. I appreciate all of the testing goodwill out there, but analysis and fixing goodwill is needed at this phase. Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ED9A2CE6-59E0-458C-A5D3-3C4AD240659E>