Date: Wed, 23 Jan 2019 23:00:08 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: "Bradley T. Hughes" <bhughes@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491058 - head/www/node8 Message-ID: <20190123220008.ctao7hiv4flbms7i@atuin.in.mat.cc> In-Reply-To: <201901232114.x0NLERHX020332@repo.freebsd.org> References: <201901232114.x0NLERHX020332@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--3x2gkxcpp5sjkdpt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 23, 2019 at 09:14:27PM +0000, Bradley T. Hughes wrote: > Author: bhughes > Date: Wed Jan 23 21:14:27 2019 > New Revision: 491058 > URL: https://svnweb.freebsd.org/changeset/ports/491058 >=20 > Log: > www/node8: convert port to use BROKEN_SSL > =20 > Sponsored by: Miles AS >=20 > Modified: > head/www/node8/Makefile >=20 > Modified: head/www/node8/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/www/node8/Makefile Wed Jan 23 21:10:26 2019 (r491057) > +++ head/www/node8/Makefile Wed Jan 23 21:14:27 2019 (r491058) > @@ -13,6 +13,8 @@ COMMENT=3D V8 JavaScript for client and server (8.x LTS) > LICENSE=3D MIT > LICENSE_FILE=3D ${WRKSRC}/LICENSE > =20 > +BROKEN_SSL=3D libressl libressl-devel > +BROKEN_SSL_REASON=3D Node.js 8.x LTS requires OpenSSL >=3D 1.0.2 or the = BUNDLED_SSL option enabled > ONLY_FOR_ARCHS=3D aarch64 amd64 armv6 armv7 i386 powerpc64 > =20 > OPTIONS_DEFINE=3D BUNDLED_SSL DOCS NLS DTRACE > @@ -62,16 +64,6 @@ MAKE_ENV+=3D CC.host=3D${CC} CXX.host=3D${CXX} LINK.ho= st=3D${C > LIB_DEPENDS+=3D libcares.so:dns/c-ares\ > libuv.so:devel/libuv \ > libnghttp2.so:www/libnghttp2 > - > -.include <bsd.port.options.mk> > - > -.if empty(PORT_OPTIONS:MBUNDLED_SSL) > - > -.if !empty(SSL_DEFAULT:Mlibressl*) > -IGNORE=3D cannot build node.js with LibreSSL. You must enable BUNDLED_S= SL > -.endif > - > -.endif Mmmm, this is not equivalent, now, the port is always marked as BROKEN if the op uses libressl* as their default SSL library, even if BUNDLED_SSL is set. And I think the other changes to the other node* ports are also wrong for the same reason. --=20 Mathieu Arnold --3x2gkxcpp5sjkdpt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlxI4+hfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkjSRQ//XO3Kkym3muihxHXynwafFfro5pxKgoJUNoH3Y8EIcBowmE8qElNQ6tnf bq/pFBg0KC+gOScJTSvPyGYFZHfPH9TLa4Z6p0nXDt5UVY+Oc9GitadaxDdgxmL2 OD+n0tT3AJu2VlRzB9t6x+YSq4SV7sjgJTTK5IP7FjbwH/grzebr6/B340Xti+QI jMHYuwB9mv8rjFq809PjIO3DB/5/EZMrBfEmlfB2fGl5aOWu5snw3blumXBloTr2 tlnF/prVkZJyB4r8r3AGTnuN0MsrsIZyTtX1RuzqK7GnZODRily0ARV+vpGGQ8mi hCglIQt6WjWvg2FBAI5gAMdxaB+XEypc+vknh67OrTUW53oWbRCf5umuVUfmkVeU xknC1RB6XjQb1nMYpkAciOAfdWOkK3fScpk5GxCussd9vEdZpfBAlJhWaJvLklDw TowomZ7+y1Ix9NT+MoWThl48SQajiYhfWdlzNcYCZehkNxXSQuVfBO+kLFyI94GD 562n9gkddQSXdwR+Yyju2nf9YzymmqBSekV8i98ExbFwxCKc9nIVMD46NpQfVYpk OjnYs7RBsZKVDBUQe1YlpF8FRarQ1aivvaodHQe3kFXJZ4/HyXQdJi7f4Cy0HFUW wSFpQGiHegUCxIgDU1lRLzbpye+68QMRYNdz5XGR08an+bFFDW0= =mqM5 -----END PGP SIGNATURE----- --3x2gkxcpp5sjkdpt--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190123220008.ctao7hiv4flbms7i>