Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 May 2018 11:36:31 +0000
From:      Antoine Brodin <antoine@freebsd.org>
To:        Hans Petter Selasky <hps@selasky.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool
Message-ID:  <CAALwa8mrWih5d9M%2BT4NxJQEOUN-hnGZ8Sp2w0=5cWTQxVv=Hrw@mail.gmail.com>
In-Reply-To: <f81ad406-4e73-d709-49f7-f42e49c5b54e@selasky.org>
References:  <201805280812.w4S8CI56046943@repo.freebsd.org> <CAALwa8n-UUS8kHmWpiGxKGBWbu4epzTCeusMPg9-FpyMaWS%2BGw@mail.gmail.com> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <CAALwa8nEAh0Xny8_YF%2B4bdCU7tDQo84-kJBcot6ZPAg9Zi9TDg@mail.gmail.com> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> <CAALwa8kMsiLxaaRgfw-qGrSfZhv2ov9wj_K3fEtRkqUnG7o0YQ@mail.gmail.com> <56e03042-872c-36df-4fea-d22a09d7ffca@selasky.org> <CAALwa8n5Lc0fvP6ec2F8Bnc7BnVDP05VT1GUtD6hsVFg68U8Ow@mail.gmail.com> <c4440e7a-0fb1-df27-0940-6093cf2ca7ca@selasky.org> <CAALwa8k4Vxwi_djFGCdZQ2o_OrVJHumJ4Khj3E6dZitdEEc8Eg@mail.gmail.com> <f81ad406-4e73-d709-49f7-f42e49c5b54e@selasky.org>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Wed, May 30, 2018 at 11:09 AM, Hans Petter Selasky <hps@selasky.org> wrote:
> On 05/30/18 12:41, Antoine Brodin wrote:
>>
>> No this won't solve the issue,  libpcap from ports isn't compiled with
>> remote support.
>
>
> Hi,
>
> Remote support is for WIN32 only from what I can see.
>
> Did you try my suggestions?
>
> The port builds fine over here with my patches.

I tried your patch with libpcap from ports updated to last commit in
github, it fails with the same error as with base libpcap.

I suggest the attached patch which fixes the issue for me.  (in my
opinion upstream should generate the pcap/pcap.h file depending on the
configure args)

Cheers,

Antoine

[-- Attachment #2 --]
Index: contrib/libpcap/pcap/pcap.h
===================================================================
--- contrib/libpcap/pcap/pcap.h	(revision 334373)
+++ contrib/libpcap/pcap/pcap.h	(working copy)
@@ -607,6 +607,7 @@
 
 #endif /* _WIN32/MSDOS/UN*X */
 
+#if 0	/* Remote capture is disabled on FreeBSD */
 /*
  * Remote capture definitions.
  *
@@ -965,6 +966,7 @@
 	    char *errbuf);
 PCAP_API int	pcap_remoteact_close(const char *host, char *errbuf);
 PCAP_API void	pcap_remoteact_cleanup(void);
+#endif	/* Remote capture is disabled on FreeBSD */
 
 #ifdef __cplusplus
 }
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8mrWih5d9M%2BT4NxJQEOUN-hnGZ8Sp2w0=5cWTQxVv=Hrw>