Date: Thu, 7 May 2009 23:21:12 +0400 From: Chagin Dmitry <dchagin@freebsd.org> To: Jamie Gritton <jamie@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191896 - in head/sys: amd64/linux32 compat/linux i386/linux kern sys Message-ID: <20090507192112.GA37183@dchagin.static.corbina.ru> In-Reply-To: <4A0333E4.1070101@FreeBSD.org> References: <200905071836.n47IalFi064565@svn.freebsd.org> <20090507185731.GA31336@dchagin.static.corbina.ru> <4A0333E4.1070101@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, May 07, 2009 at 01:17:56PM -0600, Jamie Gritton wrote: > Chagin Dmitry wrote: > > On Thu, May 07, 2009 at 06:36:47PM +0000, Jamie Gritton wrote: > >> Author: jamie > >> Date: Thu May 7 18:36:47 2009 > >> New Revision: 191896 > >> URL: http://svn.freebsd.org/changeset/base/191896 > >> > >> Log: > >> Move the per-prison Linux MIB from a private one-off pointer to the new > >> OSD-based jail extensions. This allows the Linux MIB to accessed via > >> jail_set and jail_get, and serves as a demonstration of adding jail support > >> to a module. > >> > >> Reviewed by: dchagin, kib > >> Approved by: bz (mentor) > >> > > > > > > whoops > > > > -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -c /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c > > cc1: warnings being treated as errors > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c: In function 'linux_prison_check': > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:232: warning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:243: warning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c: In function 'linux_prison_set': > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:272: warning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > /work/pub/head/sys/modules/linux/../../compat/linux/linux_mib.c:277: warning: passing argument 4 of 'vfs_getopt' from incompatible pointer type > > *** Error code 1 > > > > Stop in /work/pub/head/sys/modules/linux. > > *** Error code 1 > > Never saw that - must be something funny about compiling a Current > kernel on a Release 7 box. > > - Jamie size_t != int on some arch. # cat __tmp.patch diff --git a/sys/compat/linux/linux_mib.c b/sys/compat/linux/linux_mib.c index fd17773..c5734a0 100644 --- a/sys/compat/linux/linux_mib.c +++ b/sys/compat/linux/linux_mib.c @@ -223,7 +223,7 @@ linux_prison_check(void *obj __unused, void *data) { struct vfsoptlist *opts = data; char *osname, *osrelease; - size_t len; + int len; int error, oss_version; /* Check that the parameters are correct. */ @@ -263,7 +263,7 @@ linux_prison_set(void *obj, void *data) struct prison *pr = obj; struct vfsoptlist *opts = data; char *osname, *osrelease; - size_t len; + int len; int error, gotversion, nolinux, oss_version, yeslinux; /* Set the parameters, which should be correct. */ -- Have fun! chd [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.10 (FreeBSD) iEYEARECAAYFAkoDNKcACgkQ0t2Tb3OO/O3u0QCcD3Y0vPgOS3e6i1LKoctwqDTw VfwAnix41v6v+raihuIY7u4zyql7a7Ru =N0OA -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090507192112.GA37183>