Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Sep 2011 21:03:10 +1000
From:      Peter Jeremy <peterjeremy@acm.org>
To:        Andriy Gapon <avg@FreeBSD.org>
Cc:        freebsd-fs@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, freebsd-current@FreeBSD.org, Dimitry Andric <dim@FreeBSD.org>
Subject:   Re: ZFS: i/o error - all block copies unavailable after upgrading to r225312
Message-ID:  <20110910110310.GA6263@server.vk2pj.dyndns.org>
In-Reply-To: <4E6B320A.4090606@FreeBSD.org>
References:  <20110901223646.14b8aae8@o2.pl> <4E60DBBD.1040703@FreeBSD.org> <4E679D3D.1000007@FreeBSD.org> <4E6B1285.70508@FreeBSD.org> <4E6B1AD4.6080206@FreeBSD.org> <4E6B320A.4090606@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--zhXaljGHf11kAtnf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2011-Sep-10 12:46:50 +0300, Andriy Gapon <avg@FreeBSD.org> wrote:
>on 10/09/2011 11:07 Andriy Gapon said the following:
>> Actually, removing either -mrtd _or_ -fno-unit-at-a-time produces the co=
rrect
>> code.  Puzzled.
>
>The problem is reproducible with base gcc and gcc42, it is not reproducible
>with gcc45, gcc46 and clang.

I was just checking gcc44 & gcc46.  gcc44 inlines the entire function
and I couldn't quickly find the offending code to see if the bug was
there or not.  I agree you've triggered a gcc bug but I'm not sure of
the correct approach to fix it.  I've tried a few trivial code
transforms within vdev_read_phys() but haven't stumbled on one that
avoids the problem.

Since -mrtd changes the calling convention, it's a more intrusive
change.  I'm not sure if there's any simple way to alter CFLAGS for
a single file (since we only want to alter the zfsboot.c compilation.

--=20
Peter Jeremy

--zhXaljGHf11kAtnf
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (FreeBSD)

iEYEARECAAYFAk5rQ+4ACgkQ/opHv/APuIdXagCeMrMRpjGHkXnmxlmUG0v7GUGG
YZgAoLzV4ypU07F261aURRMIARZa+2VF
=imQJ
-----END PGP SIGNATURE-----

--zhXaljGHf11kAtnf--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110910110310.GA6263>