Date: Sat, 11 Nov 1995 11:20:33 +0200 From: Heikki Suonsivu <hsu@clinet.fi> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/816: fsck -y ignores clean flag Message-ID: <199511110920.LAA08775@katiska.clinet.fi> Resent-Message-ID: <199511110930.BAA09451@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 816
>Category: bin
>Synopsis: fsck -y ignores clean flag
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Nov 11 01:30:01 PST 1995
>Last-Modified:
>Originator: Heikki Suonsivu
>Organization:
Clinet, Espoo, Finland
>Release: FreeBSD 2.1.0-950928-SNAP i386
>Environment:
A news server, with news disk mounted with -o async and
fsck -y in /etc/rc before other fsck's to clean up the mess
after a panic.
>Description:
fsck -y causes clean bit to be ignored. This is nasty as fsck
-y is necessary with -o async, and getting a full news feed needs
-o async. But currently it takes forever to reboot the news server
because it will do a forced check on the news spool.
>How-To-Repeat:
reboot a system cleanly, but boot into single user, and do an fsck
for a clean disk with -y. It will do a forced check on the disk.
>Fix:
I think this ...
if (preen && sblock.fs_clean && !fflag) {
pwarn("clean, %ld free ", sblock.fs_cstotal.cs_nffree +
sblock.fs_frag * sblock.fs_cstotal.cs_nbfree);
printf("(%ld frags, %ld blocks, %.1f%% fragmentation)\n",
... should be changed into
if (sblock.fs_clean && !fflag) {
pwarn("clean, %ld free ", sblock.fs_cstotal.cs_nffree +
sblock.fs_frag * sblock.fs_cstotal.cs_nbfree);
printf("(%ld frags, %ld blocks, %.1f%% fragmentation)\n",
ie. always check the clean flag unless -f has been specified.
I don't know if there is any change a disk could look clean even if it
has been modified, if there are they need to be fixed first (writing
the clean flag off on first access?)
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511110920.LAA08775>