Date: Wed, 4 Jul 2007 17:15:12 +0200 From: "Attilio Rao" <attilio@freebsd.org> To: "Rui Paulo" <rpaulo@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 122829 for review Message-ID: <3bbf2fe10707040815u522d3580m445d27d60d58228@mail.gmail.com> In-Reply-To: <200707040343.l643hQ2i073492@repoman.freebsd.org> References: <200707040343.l643hQ2i073492@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
2007/7/4, Rui Paulo <rpaulo@freebsd.org>:
> struct asmc_softc {
> - device_t sc_dev;
> - struct mtx sc_mtx;
> -
> - int sc_nfan;
> -
> - int16_t sms_rest_x;
> - int16_t sms_rest_y;
> - int16_t sms_rest_z;
> -
> + device_t sc_dev;
> + struct mtx sc_mtx;
> + int sc_nfan;
> + int16_t sms_rest_x;
> + int16_t sms_rest_y;
> + int16_t sms_rest_z;
> struct sysctl_ctx_list sc_sysctl_ctx;
> - struct sysctl_oid *sc_root_tree;
> - struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS+1];
> - struct sysctl_oid *sc_temp_tree;
> - struct sysctl_oid *sc_sms_tree;
> -
> - struct asmc_model *sc_model;
> -
> - int sc_rid;
> - struct resource *sc_res;
> - void *sc_cookie;
> -
> - int sms_intrtype;
> - struct taskqueue *sms_tq;
> - struct task sms_task;
> + struct sysctl_oid *sc_root_tree;
> + struct sysctl_oid *sc_fan_tree[ASMC_MAXFANS+1];
> + struct sysctl_oid *sc_temp_tree;
> + struct sysctl_oid *sc_sms_tree;
> + struct asmc_model *sc_model;
> + int sc_rid;
> + struct resource *sc_res;
> + void *sc_cookie;
> + int sms_intrtype;
> + struct taskqueue *sms_tq;
> + struct task sms_task;
> };
Members of the same struct should have the same name prefix, in this
case you should not mix between sc_ and sms_.
Attilio
--
Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10707040815u522d3580m445d27d60d58228>