Date: Wed, 5 Sep 2001 05:31:42 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: John Baldwin <jhb@FreeBSD.org>, "David E. O'Brien" <obrien@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010905052114.I18060-100000@alphplex.bde.org> In-Reply-To: <20010904195711.A16547@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Sep 2001, Ruslan Ermilov wrote:
> On Tue, Sep 04, 2001 at 09:51:52AM -0700, John Baldwin wrote:
> >
> > On 04-Sep-01 David E. O'Brien wrote:
> > > obrien 2001/09/04 03:00:20 PDT
> > >
> > > Modified files:
> > > share/man/man9 style.9
> > > Log:
> > > Fix style bug from rev 1.20 in `struct foo' definition example to match the
> > > `struct foo' definition example from rev 1.1.
> > >
> > > (proper CSRG style was also verified with /sys/sys/{bio,file}.h)
> >
> > Erm, according to bruce, the struct<tab>foo is the proper style.
Also according to: style(9):
Put a tab after the first word, i.e. use
.Ql int^Ix;
and
.Ql struct^Ifoo *x; .
> This rule only applies when inside the structure declaration.
This is not clear (see the above rule).
>
> > You'll need to reformat a lot of files then.
> >
> Much less than in the opposite direction:
>
> # grep -r "^struct^I" /CURRENT/usr/include | wc -l
> 514
> # grep -r "^struct " /CURRENT/usr/include | wc -l
> 3034
I think you'll find that old code and system code follow the tab rule
more. The counts in <sys> are:
# grep -r "^struct^I" /CURRENT/usr/include/sys | wc -l
367
# grep -r "^struct " /CURRENT/usr/include/sys | wc -l
491
# grep -r "^struct^I" /4.4BSD-Lite2/usr/include/sys | wc -l
60
# grep -r "^struct " /4.4.BSD-Lite2/usr/include/sys | wc -l
325
Oops, so much for that theory (but about half of the "struct "'s in Lite2
are in the machine-generated syscallargs.h).
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010905052114.I18060-100000>