Date: Fri, 26 Jul 2013 14:26:08 -0700 From: Andrey Zonov <zont@FreeBSD.org> To: Jilles Tjoelker <jilles@stack.nl> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc Message-ID: <51F2E970.3070303@FreeBSD.org> In-Reply-To: <20130726150949.GC14175@stack.nl> References: <201307260200.r6Q207cB015223@svn.freebsd.org> <20130726150949.GC14175@stack.nl>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WRQWRTFUJEHNMFAEIMTQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 7/26/13 8:09 AM, Jilles Tjoelker wrote: > On Fri, Jul 26, 2013 at 02:00:07AM +0000, Andrey Zonov wrote: >> Author: zont >> Date: Fri Jul 26 02:00:06 2013 >> New Revision: 253662 >> URL: http://svnweb.freebsd.org/changeset/base/253662 >=20 >> Log: >> Remove define and documentation for vm_pageout_algorithm missed in r= 253587 >=20 >> Modified: >> head/lib/libc/gen/sysctl.3 >> head/sys/vm/vm_param.h >> head/tools/tools/sysdoc/tunables.mdoc >=20 >> Modified: head/sys/vm/vm_param.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/vm/vm_param.h Fri Jul 26 00:28:19 2013 (r253661) >> +++ head/sys/vm/vm_param.h Fri Jul 26 02:00:06 2013 (r253662) >> @@ -82,9 +82,8 @@ >> #define VM_V_CACHE_MIN 7 /* cnt.v_cache_min */ >> #define VM_V_CACHE_MAX 8 /* cnt.v_cache_max */ >> #define VM_V_PAGEOUT_FREE_MIN 9 /* cnt.v_pageout_free_min */ >> -#define VM_PAGEOUT_ALGORITHM 10 /* pageout algorithm */ >> -#define VM_SWAPPING_ENABLED 11 /* swapping enabled */ >> -#define VM_MAXID 12 /* number of valid vm ids */ >> +#define VM_SWAPPING_ENABLED 10 /* swapping enabled */ >> +#define VM_MAXID 11 /* number of valid vm ids */ >=20 > As noted in mail from Bruce Evans, please preserve the ABI of > VM_SWAPPING_ENABLED here. >=20 I don't think it's a big problem. Internally we don't use it. Good code uses sysctlbyname() instead of sysctl(). It doesn't seem to me this is very popular sysctl. It's also CURRENT without MFC. I prefer clean code where it is possible instead of "dummy" all around. >> #define CTL_VM_NAMES { \ >> { 0, 0 }, \ >> @@ -97,7 +96,6 @@ >> { "v_cache_min", CTLTYPE_UINT }, \ >> { "v_cache_max", CTLTYPE_UINT }, \ >> { "v_pageout_free_min", CTLTYPE_UINT}, \ >> - { "pageout_algorithm", CTLTYPE_INT}, \ >> { "swap_enabled", CTLTYPE_INT},\ >> } >=20 > This should be replaced with some sort of dummy rather than replaced > entirely (does not matter very much because it should not be used). >=20 --=20 Andrey Zonov ------enig2WRQWRTFUJEHNMFAEIMTQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJR8ulzAAoJEBWLemxX/CvTTlMH/AqmYR7Ytm79iDPmZlr4DlDT yQYym8KSY97I6/20E7o4P83j9G8fsbCSnzBF53SfdhsAlB4lENU7sqeMxvvWTlHm 2gQIQ0vXMKUMev+kulVMC/KY53CqCL2Z/akCeny7MwNK2hrUYVFsBjdVQWoDOxrZ fLN2Br1sv+ji4ShcaWYRVnZrYuV8QyfWA4BUssyTM6cPFPHNc/z+ybGNUTPjqt43 dGhudoSyV9IR8ypuutZOlSYHqkGV1+mALS9RLjzMLPnNPUmUqkKC3vtPRFFjc2T5 Ql03zr7VBeos1aRg80Yu1N5sRXV3XwK35imGjTnKmhK9URJPyzc8TNvjoqLzdJY= =fZaL -----END PGP SIGNATURE----- ------enig2WRQWRTFUJEHNMFAEIMTQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51F2E970.3070303>